-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Preview and Thumbnail Extension #59
base: master
Are you sure you want to change the base?
Conversation
nostradani
commented
Nov 7, 2024
- macOS 10.15 deprecated and removed support for quicklook generators
- Since macOS 12, an extension can be created to provide Quicklook previews
- This change implements this in addition to the existing quicklook generator
- Code has been refactored to share the existing implementation with both approaches
- Since app extensions are sandboxed, the usage of NSTask had to be replaced. This has also been done und thus offers now also better performance
Hi, @nostradani, thanks for this! If I build the repo using your branch, will this work locally for me? I've been missing ProvisionQL for some time now and don't want to wait for this PR to be merged and then a new release. Thanks! |
@gabrielmaldi Yes, you should be able to build this locally. More precisely, you need to build the ProvisionQLApp, copy it to your Applications folder and run it at least once (you can directly close it then). That should give you back the quicklook preview functionality. Regarding the thumbnails: I don't know why this doesn't work for me anymore (at the moment). Let me know whether it works for you. |
@nostradani, THANK YOU! I missed so much this QL extension. It's working perfectly now. I didn't even need to copy the app, after building it in Xcode I just got a System Settings notification and enabled it: Wrt the thumbnail, is this what you mean? Fyi, I had to make this change: |
Do you have anything for APKs? I used https://github.com/ArtRoman/QuickLookAPK but it's not working anymore. Would you say it's a lot of work to make it work in Sequoia? Thanks again. |
It’ll be in your Xcode DevidedData folder, so you risk it being deleted/cleaned at some point. Best moving it to the Applications folder. |
I don't develop for Android, but I quickly checked the project. The structure would be easy to migrate. There are already methods that provide the needed content, so you would just have to plug it into the new API. However it also uses NSTask, which I had to remove here due to sandboxing. That must be done there as well, but I noticed that it's using a tool named aapt which I cannot simply replace. Not sure whether we can run it when its bundled with the plugin... |
Thanks for looking into it! In https://github.com/ArtRoman/QuickLookAPK/blob/master/QuickLookAPK/HZAndroidPackage.m I can see that it also uses |
Showing Recent Messages ZIPFoundationObjC Updating from https://github.com/nostradani/ZIPFoundationObjC.git Resolving Package Graph Failed 2024/11/10, 22:54 3.9 seconds |
@ipad4, make this change:
|