Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix verbage in pagination.py #185

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions graphene_django_extras/paginations/pagination.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def __init__(
# A string value indicating the name of the "offset" query parameter.
self.offset_query_param = offset_query_param

# A string or tuple/list of strings that indicating the default ordering when obtaining lists of objects.
# A string or tuple/list of strings that indicates the default ordering when obtaining lists of objects.
# Uses Django order_by syntax
self.ordering_param = ordering_param

Expand All @@ -97,7 +97,7 @@ def to_graphql_fields(self):
description="The initial index from which to return the results. Default: 0"
),
self.ordering_param: String(
description="A string or comma delimited string values that indicate the "
description="A string or comma delimited string value that indicates the "
"default ordering when obtaining lists of objects."
),
}
Expand Down Expand Up @@ -155,7 +155,7 @@ def __init__(
# Default ordering value: ""
self.ordering = ordering

# A string or comma delimited string values that indicate the default ordering when obtaining lists of objects.
# A string or comma delimited string value that indicates the default ordering when obtaining lists of objects.
# Uses Django order_by syntax
self.ordering_param = ordering_param

Expand All @@ -180,7 +180,7 @@ def to_graphql_fields(self):
description="A page number within the result paginated set. Default: 1",
),
self.ordering_param: String(
description="A string or comma delimited string values that indicate the "
description="A string or comma delimited string value that indicates the "
"default ordering when obtaining lists of objects."
),
}
Expand Down Expand Up @@ -266,5 +266,5 @@ def to_graphql_fields(self):

def paginate_queryset(self, qs, **kwargs):
raise NotImplementedError(
"paginate_queryset() on CursorGraphqlPagination are not implemented yet."
"paginate_queryset() on CursorGraphqlPagination is not implemented yet."
)