Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PICO_FLASH_SIZE_BYTES to PIO #1416

Merged
merged 2 commits into from
May 1, 2023
Merged

Add PICO_FLASH_SIZE_BYTES to PIO #1416

merged 2 commits into from
May 1, 2023

Conversation

maxgerhardt
Copy link
Contributor

Complementary to #1414 for PlatformIO's defines.

Tested with

board = waveshare_rp2040_plus_16mb
board_build.filesystem_size = 1m

and it gives indeed the full

-DPICO_FLASH_SIZE_BYTES=16777216

which is exactly 16*1024*1024.

earlephilhower
earlephilhower approved these changes May 1, 2023
View reviewed changes
Copy link
Owner

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, slipped my mind to update P.IO, too. Thx!

@earlephilhower earlephilhower merged commit a916695 into earlephilhower:master May 1, 2023
@maxgerhardt
Copy link
Contributor Author

No problem that's what I'm here for, the burden of PlatformIO support shouldn't be primarily on you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earlephilhower earlephilhower earlephilhower approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxgerhardt @earlephilhower