Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix I2S::write(const uint8_t *buffer, size_t size) #1461

Merged
merged 3 commits into from
May 20, 2023
Merged

Fix I2S::write(const uint8_t *buffer, size_t size) #1461

merged 3 commits into from
May 20, 2023

Conversation

LinusHeu
Copy link
Contributor

@LinusHeu LinusHeu commented May 20, 2023 •
edited
Loading

According to #1450
Added || !_running || !_isOutput for consistency with the other methods.

earlephilhower
earlephilhower approved these changes May 20, 2023
View reviewed changes
Copy link
Owner

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@earlephilhower earlephilhower merged commit 3b4fb29 into earlephilhower:master May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earlephilhower earlephilhower earlephilhower approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LinusHeu @earlephilhower