Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linker tweaks to place vital PicoDVI library funcs in RAM #1541

Merged
merged 3 commits into from
Jun 15, 2023

Conversation

PaintYourDragon
Copy link
Contributor

As discussed in previous issue (which I’ll go close in a moment), adjustments to linker script to place certain code in RAM, required for PicoDVI library when used in combination with flash-writing code (e.g. filesystem).

If you’d prefer, I could go through PicoDVI.cpp and dvi.c and extensively decorate all functions there as not-in-flash (so they could then be removed here), but regardless this is still going to require *interp.c.obj *divider.S.obj in the linker script.

For non-PicoDVI projects, interp and divider are obscure and/or small such that they’ll have minimal or no impact on RAM.

Copy link
Owner

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@earlephilhower earlephilhower merged commit fa7c287 into earlephilhower:master Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants