Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BTstackLib: added function to set scan respone data. #2134

Merged
merged 1 commit into from
Apr 29, 2024
Merged

BTstackLib: added function to set scan respone data. #2134

merged 1 commit into from
Apr 29, 2024

Conversation

djpearman
Copy link
Contributor

Hi,

I added a function to set the BLE scan response data via BTstackManager - essentially just a wrapper around the underlying BTstack function. The passed data must be structured in the same manner as advertising data.

Best regards,
djpearman

earlephilhower
earlephilhower approved these changes Apr 29, 2024
View reviewed changes
Copy link
Owner

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, but man does the converting of a const uint8_t * to a non-const uint8_t * bother me. But I get that's the way they wrote everything. :(

@earlephilhower earlephilhower merged commit a439028 into earlephilhower:master Apr 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earlephilhower earlephilhower earlephilhower approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djpearman @earlephilhower