Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix D pins mapping on Adafruit IB RP2040 #2259

Merged
merged 5 commits into from
Jul 12, 2024
Merged

Fix D pins mapping on Adafruit IB RP2040 #2259

merged 5 commits into from
Jul 12, 2024

Conversation

AcThPaU
Copy link
Contributor

@AcThPaU AcThPaU commented Jul 12, 2024 •
edited
Loading

Fix D pins mapping on Adafruit itsybitsy RP2040 and Adafruit Feather RP2040

earlephilhower
earlephilhower requested changes Jul 12, 2024
View reviewed changes
Copy link
Owner

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you please button up the last bits and then we can merge!

variants/adafruit_feather/pins_arduino.h Show resolved Hide resolved
variants/adafruit_itsybitsy/pins_arduino.h Show resolved Hide resolved
@dhalbert
Copy link
Contributor

@ladyada Someone from Adafuit should look this over.

@AcThPaU
Copy link
Contributor Author

AcThPaU commented Jul 12, 2024

OK. I added fix to itsybitsy with the format that new common.h should accept. I need to sleep for the day, and maybe people from Adafruit can fix the rest of the boards.

earlephilhower
earlephilhower approved these changes Jul 12, 2024
View reviewed changes
Copy link
Owner

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I fixed the 3 Feather pin define names and will give a sanity check and CI run on this now.

@earlephilhower earlephilhower merged commit a584d10 into earlephilhower:master Jul 12, 2024
13 checks passed
@ladyada
Copy link
Contributor

ladyada commented Jul 13, 2024

reviewd, looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada left review comments

@earlephilhower earlephilhower earlephilhower approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AcThPaU @dhalbert @ladyada @earlephilhower