Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getStackPointer() to work in RISC-V and ARM mode #2526

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Fix getStackPointer() to work in RISC-V and ARM mode #2526

merged 1 commit into from
Oct 6, 2024

Conversation

maxgerhardt
Copy link
Contributor

@maxgerhardt maxgerhardt commented Oct 6, 2024 •
edited
Loading

Fixes #2525.

Tested on RISC-V with a debugger to match.

"mv" instruction to move one register's content into another register, see https://projectf.io/posts/riscv-cheat-sheet/#misc-instructions.

grafik

earlephilhower
earlephilhower approved these changes Oct 6, 2024
View reviewed changes
Copy link
Owner

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@earlephilhower earlephilhower merged commit 58c0d95 into earlephilhower:master Oct 6, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earlephilhower earlephilhower earlephilhower approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RISC-V : RP2040.getStackPointer has ARM code inlined
2 participants
@maxgerhardt @earlephilhower