Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow littlefs file name spec, update for compiling for c++ 20, update gitignore for binaries #43

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

Szybet
Copy link
Contributor

@Szybet Szybet commented Jun 2, 2024

As described here:
arduino-libraries/Arduino_UnifiedStorage#42
This tool, and littlefs implementation here: https://github.com/esp8266/Arduino are the only ones using LFS_NAME_MAX=32 instead of 255

@earlephilhower
Copy link
Owner

Thanks for the note and the update for C++20.

Actually, the RP2040 arduino-pico is running at 32 as well, because I did both those implementations and just copied from the 8266 work. :) On the 8266 there's so little RAM and stack that the difference between 32 and 256 byte file lengths was significant but I think in 2024 that's no longer the case on non-EOL devices.

Let me do some code reading to verify this change won't break the 8266 or Pico (although I will update to 255 on the Pico by the next release) before merging.

@earlephilhower earlephilhower self-assigned this Jun 3, 2024
@earlephilhower
Copy link
Owner

Looks like this will change the on-flash format enough to break existing code on the 8266. The superblock will have 255 while the lfs configuration will have 32 and it will error on mounting.
https://github.com/littlefs-project/littlefs/blob/d01280e64934a09ba16cac60cf9d3a37e228bb66/lfs.c#L4486-L4493

That said, the toolchain is already built and the 8266 core is basically archived now so we can just leave them at the earlier release they are using and move forward.

@earlephilhower earlephilhower merged commit 8430791 into earlephilhower:master Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants