-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow defaultGitImage to be a configurable value #2027
Comments
That's awesome to hear you were able to rebuild it and it worked. We'll accept a PR for such a feature; then once it's fixed upstream we could evaluate if it's still needed. The Line 34 in fd5029a
which gets created via earthly/buildcontext/resolver.go Line 59 in fd5029a
the Line 122 in fd5029a
Line 52 in fd5029a
GitImage string added to it.
it gets set via earthly/cmd/earthly/build_cmd.go Line 389 in fd5029a
then finally a new Line 59 in fd5029a
which would then show up under build_cmd.go under I'll gladly help out if you run into any roadblocks along the way. |
@alexcb -- I appreciate the detailed guide. Thank you. I'd be happy to take this on. |
this should be fixed/implemented now. (see above PR) |
We are testing earthly behind our corporate firewall that has no Internet access. We use artifactory as a pull through docker cache.
I am unable to use artifactory as a proper pull through cache because authentication details are not passed to docker, apparently because of this issue.
As an alternative to having an nginx frontend that can handle the authentication to our registry cache, I am hoping you'd be willing to allow the defaultGitImage to be an image that could be defined in
~/.earthly/config.yml
.I was able to verify git operations in earthly behind our firewall by building my own earthly docker image, changing the defaultGitImage in
buildcontent/git.go
to point to the same image in our artifactory instance, but would love to see this in the core earthly docker image so I don't have to build custom images from source.Thanks for your consideration.
The text was updated successfully, but these errors were encountered: