-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log transferring #1051
Log transferring #1051
Conversation
7a2e241
to
042f738
Compare
buildkitd/Earthfile
Outdated
@@ -11,7 +11,7 @@ buildkitd: | |||
ARG BUILDKIT_BASE_IMAGE=$BUILDKIT_PROJECT+build | |||
END | |||
ELSE | |||
ARG BUILDKIT_BASE_IMAGE=github.com/earthly/buildkit:c896a903b73a001a756c8d40330874451dbe38c4+build | |||
ARG BUILDKIT_BASE_IMAGE=github.com/earthly/buildkit:907351dab34de3d22aeebea7a03593473ab7a1f0+build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update this once earthly/buildkit#44 is merged.
I wonder if the file stat updates can be made less verbose. For example by printing how many files+dirs were stat'd per tree, instead of listing every single file. |
We would need some additional changes to fsutils to differentiate between files and dirs, but we could count the total number of stats per walk. Another possibility would be to change |
Yeah, total number would be great. I'd avoid multiple levels of verbosity, to keep things simple. |
293ca7b
to
2fd5dd3
Compare
That looks really good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit
When running in verbose mode, log which files are sent to buildkit including file stats and files which are excluded (ignored). Signed-off-by: Alex Couture-Beil <alex@earthly.dev>
log files which are sent to buildkit
When running in verbose mode, log which files are sent to buildkit including file stats and files which are excluded (ignored).
In regular (non-verbose) mode, the progressbars have been replaced with a message displaying total bytes sent:
and under verbose mode, it displays all files:
The progress bar had to be removed as it was overwriting the final output of text while running in verbose mode, and to be able to programatically disable it for only verbose mode would have required a fair amount of changes to the buildkit code.
This depends on earthly/buildkit#44