Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SAVE IMAGE --push contextual within RUNs #754

Merged
merged 20 commits into from
Feb 10, 2021
Merged

Conversation

dchw
Copy link
Collaborator

@dchw dchw commented Feb 1, 2021

This should allow the changes effected by a RUN --push to show in an image, when a SAVE IMAGE --push follows. SAVE IMAGE --push will not save locally unless it is the first -push command.

Copy link
Member

@vladaionescu vladaionescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in builder make sense. I don't fully understand the changes in converter - so I left some comments.

earthfile2llb/converter.go Outdated Show resolved Hide resolved
earthfile2llb/converter.go Outdated Show resolved Hide resolved
earthfile2llb/converter.go Outdated Show resolved Hide resolved
@dchw
Copy link
Collaborator Author

dchw commented Feb 9, 2021

Merged in, and tested with --enable-ast as well. I can add tests for that if needed? We would need to remove them when the AST is GA.

Copy link
Member

@vladaionescu vladaionescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - minor comment.

Let's merge this after the release.

.github/workflows/ci.yml Show resolved Hide resolved
@dchw dchw merged commit c7778d6 into main Feb 10, 2021
@dchw dchw deleted the corey/fix-save-image-push branch February 10, 2021 18:13
@dchw
Copy link
Collaborator Author

dchw commented Feb 10, 2021

This is the other part needed for #586.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants