-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make SAVE IMAGE --push
contextual within RUN
s
#754
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in builder make sense. I don't fully understand the changes in converter - so I left some comments.
Merged in, and tested with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - minor comment.
Let's merge this after the release.
This is the other part needed for #586. |
This should allow the changes effected by a
RUN --push
to show in an image, when aSAVE IMAGE --push
follows.SAVE IMAGE --push
will not save locally unless it is the first-push
command.