Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command not found: poe, because h5py fails to install #786

Closed
amotl opened this issue Nov 15, 2022 · 9 comments · Fixed by #787
Closed

Command not found: poe, because h5py fails to install #786

amotl opened this issue Nov 15, 2022 · 9 comments · Fixed by #787

Comments

@amotl
Copy link
Member

amotl commented Nov 15, 2022

On CI, the Install project workflow step reports that installing h5py fails. As a consequence, poe will not be available, because the installation of dependencies terminated.

I am wondering why the corresponding command 1 did not croak appropriately? I would have expected that the Install project workflow step would fail correctly.

-- https://github.com/earthobservations/wetterdienst/actions/runs/3465808093/jobs/5789593334#step:5:139

Originally posted by @amotl in #785 (comment)

Footnotes

  1. poetry install --no-interaction --extras=sql --extras=export --extras=restapi --extras=explorer --extras=interpolation

@amotl
Copy link
Member Author

amotl commented Nov 15, 2022

I can confirm it works like that. Maybe the CI setup will need a corresponding adjustment?

docker run --rm -it python:3.11-slim-bullseye bash
apt-get update && apt-get install --yes build-essential pkg-config libhdf5-dev
pip install wheel
pip install h5py
python
>>> import h5py
>>> h5py.__version__
'3.7.0'

@amotl
Copy link
Member Author

amotl commented Nov 15, 2022

Despite of a SolverProblemError [1], the workflow step Install project succeeds. There is something wrong, no?

[1] https://github.com/earthobservations/wetterdienst/actions/runs/3466760679/jobs/5790954548#step:6:18

@amotl
Copy link
Member Author

amotl commented Nov 15, 2022

Specifically: Is h5py actually part of our baseline requirements, or not? Do we need it only for running the test suite?

-- #787 (comment)

The radar tests at tests\provider\dwd\radar\test_api_historic.py needs h5py, see [1]. How did it work on Windows up until now?

[1] https://github.com/earthobservations/wetterdienst/actions/runs/3466910653/jobs/5791255793#step:7:68

@amotl
Copy link
Member Author

amotl commented Nov 15, 2022

Looks like installing h5py worked well only a few days ago, even on Python 3.11/macOS, using Poetry 1.2.2, e.g. at [1].

[1] https://github.com/earthobservations/wetterdienst/actions/runs/3406246127/jobs/5664802933#step:5:130

@amotl
Copy link
Member Author

amotl commented Nov 15, 2022

I am wondering why the corresponding command did not croak appropriately? I would have expected that the Install project workflow step would fail correctly.

Similar thing why I think the setup does not behave well: DuckDB fails to install, but nothing indicates that the process croaked. Why is that?

-- https://github.com/earthobservations/wetterdienst/actions/runs/3467576650/jobs/5792575196#step:6:256

@amotl

This comment was marked as resolved.

@amotl

This comment was marked as resolved.

@amotl
Copy link
Member Author

amotl commented Nov 16, 2022

I am wondering why the corresponding command did not croak appropriately? I would have expected that the Install project workflow step would fail correctly.

Similar thing why I think the setup does not behave well: DuckDB fails to install, but nothing indicates that the process croaked. Why is that?

dbd97a8 improves the .github/workflows/install.sh program. Now, it will croak when any of the project setup command fails.

@amotl
Copy link
Member Author

amotl commented Nov 16, 2022

#787 will hopefully resolve this issue, and #788 will further modernize the project and CI configuration.

@amotl amotl linked a pull request Nov 16, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant