-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize Poetry configuration and project dependencies #788
Conversation
de2f301
to
cf947ec
Compare
2fb5c21
to
4cfe043
Compare
ruff==0.0.46 ; python_version >= "3.8" and python_version < "3.12" | ||
ruff==0.0.120 ; python_version >= "3.8" and python_version < "3.12" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is ruff
still part of the requirements.txt
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. The export to requirements.txt
includes development dependencies. Is it intended like this? If the Anaconda packages will derive its runtime dependencies from this list, maybe we should change it? See also conda-forge/wetterdienst-feedstock#57.
In order to provide a corresponding file including the development dependencies, we can use a different file name, like requirements-dev.txt
.
export_requirements_runtime = "poetry export --without-hashes --output requirements.txt"
export_requirements_sandbox = "poetry export --without-hashes --with=dev,test --output requirements-sandbox.txt"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #790.
4cfe043
to
b038efe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work!
Just added a small comment.
c3c622f
to
ed86bb6
Compare
Codecov ReportBase: 90.46% // Head: 90.72% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #788 +/- ##
==========================================
+ Coverage 90.46% 90.72% +0.25%
==========================================
Files 88 88
Lines 6201 6201
Branches 616 616
==========================================
+ Hits 5610 5626 +16
+ Misses 449 436 -13
+ Partials 142 139 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ed86bb6
to
4c491b8
Compare
A few modernizations and dependency package version bumps.
pytest
and friends.mock
package, useunittest.mock
instead.py
package, it will automatically resolve [1] and [2].[1] https://github.com/earthobservations/wetterdienst/security/dependabot/11
[2] https://github.com/earthobservations/wetterdienst/security/dependabot/12