NWS API: Adjust User-Agent header
#792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
commented
Nov 21, 2022
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| import pandas as pd | |||
|
|
|||
| from wetterdienst import __version__ | |||
There was a problem hiding this comment.
Bummer.
ImportError: cannot import name '__version__' from partially initialized module 'wetterdienst' (most likely due to a circular import) (/home/runner/work/wetterdienst/wetterdienst/wetterdienst/__init__.py)
amotl
force-pushed
the
amo/nws-adjust-user-agent
branch
from
7ee8a62 to
a5bac17
Compare
amotl
commented
Nov 21, 2022
| "User-Agent": "wetterdienst/gutzemann@gmail.com", | ||
| "User-Agent": "wetterdienst/0.48.0", |
There was a problem hiding this comment.
Until we can use the real version number at runtime, I think it will be better than nothing.
There was a problem hiding this comment.
The reason I put my mail there is their hint
"""
Authentication
A User Agent is required to identify your application. This string can be anything, and the more unique to your application the less likely it will be affected by a security event. If you include contact information (website or email), we can contact you if your string is associated to a security event. This will be replaced with an API key in the future.
User-Agent: (myweatherapp.com, contact@myweatherapp.com)
"""
|
I think there's no need to obey on this level. Never seen that. We can just include the URL to the repository instead, if you really feel we should.
|
gutzbenj
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming from #781 (comment), this is hopefully a minor, but sensible improvement. Please let me know if you think it's not.