Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: Stop exporting requirements.txt files #794

Merged
merged 7 commits into from
Nov 24, 2022

Conversation

amotl
Copy link
Member

@amotl amotl commented Nov 21, 2022

Distribute different Poetry dependency groups to different requirements.txt files for improved sanity.

Completely get rid of requirements.txt files at all.

Reference: #790 (comment)

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Base: 90.54% // Head: 90.79% // Increases project coverage by +0.25% 🎉

Coverage data is based on head (d96e2eb) compared to base (646709c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #794      +/-   ##
==========================================
+ Coverage   90.54%   90.79%   +0.25%     
==========================================
  Files          90       90              
  Lines        6304     6304              
  Branches      619      619              
==========================================
+ Hits         5708     5724      +16     
+ Misses        453      440      -13     
+ Partials      143      140       -3     
Flag Coverage Δ
unittests 90.79% <ø> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wetterdienst/ui/explorer/app.py 87.56% <0.00%> (+6.48%) ⬆️
wetterdienst/ui/explorer/library.py 100.00% <0.00%> (+30.76%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@amotl amotl force-pushed the amo/better-requirements branch from 1c78f0e to 724506a Compare November 22, 2022 00:10
@amotl
Copy link
Member Author

amotl commented Nov 23, 2022

Dear Benjamin,

at #790 (comment), you said:

I just checked the details again and Github seems to support pyproject.toml now.

I think it would still be worth to keep those requirements{-dev}.txt files, in order to support people from the community who are not able to use Poetry, for whatever reasons. What do you think?

With kind regards,
Andreas.

Distribute different Poetry dependency groups to different
`requirements.txt` files for improved sanity.
This will install the requirements directly from `pyproject.toml`, there
is no need to use a specific `requirements.txt` file.
@gutzbenj
Copy link
Member

Dear @amotl ,

honestly I like the pyproject.toml format much more and one should still be able to install it with pip as documented here [1]. But if you believe we should keep it, then that's the way to go!

[1] https://pip.pypa.io/en/stable/reference/build-system/pyproject-toml/

@amotl
Copy link
Member Author

amotl commented Nov 23, 2022

You are right, since setuptools now also understands pyproject.toml, even in editable mode, I think it is safe to completely remove all sorts of requirements{-*}.txt files, in order to avoid confusion and reduce maintenance.

@amotl amotl force-pushed the amo/better-requirements branch from 724506a to 65ac6a0 Compare November 23, 2022 19:15
@amotl amotl changed the title Dependencies: Streamline export of requirements.txt files Dependencies: Stop exporting requirements.txt files Nov 23, 2022
@amotl amotl force-pushed the amo/better-requirements branch 5 times, most recently from 6fed3e7 to 5b9ed4b Compare November 23, 2022 20:03
@amotl amotl force-pushed the amo/better-requirements branch from 5b9ed4b to 6878e66 Compare November 23, 2022 20:27
@amotl amotl requested a review from gutzbenj November 23, 2022 20:39
@amotl amotl marked this pull request as ready for review November 23, 2022 20:39
@amotl amotl force-pushed the amo/better-requirements branch from 6878e66 to 96a3d8f Compare November 23, 2022 20:40
The test case produces a different result on the GHA/macOS environment.

[should]: [273.65, 267.65, 270.45]
[is]:     [272.95, 266.15, 268.75]
@gutzbenj gutzbenj merged commit 903066c into main Nov 24, 2022
@gutzbenj gutzbenj deleted the amo/better-requirements branch November 24, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants