-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependencies: Stop exporting requirements.txt
files
#794
Conversation
Codecov ReportBase: 90.54% // Head: 90.79% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #794 +/- ##
==========================================
+ Coverage 90.54% 90.79% +0.25%
==========================================
Files 90 90
Lines 6304 6304
Branches 619 619
==========================================
+ Hits 5708 5724 +16
+ Misses 453 440 -13
+ Partials 143 140 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
1c78f0e
to
724506a
Compare
Dear Benjamin, at #790 (comment), you said:
I think it would still be worth to keep those With kind regards, |
Distribute different Poetry dependency groups to different `requirements.txt` files for improved sanity.
This will install the requirements directly from `pyproject.toml`, there is no need to use a specific `requirements.txt` file.
Dear @amotl , honestly I like the pyproject.toml format much more and one should still be able to install it with pip as documented here [1]. But if you believe we should keep it, then that's the way to go! [1] https://pip.pypa.io/en/stable/reference/build-system/pyproject-toml/ |
You are right, since |
724506a
to
65ac6a0
Compare
requirements.txt
filesrequirements.txt
files
6fed3e7
to
5b9ed4b
Compare
5b9ed4b
to
6878e66
Compare
6878e66
to
96a3d8f
Compare
The test case produces a different result on the GHA/macOS environment. [should]: [273.65, 267.65, 270.45] [is]: [272.95, 266.15, 268.75]
Distribute different Poetry dependency groups to differentrequirements.txt
files for improved sanity.Completely get rid of
requirements.txt
files at all.Reference: #790 (comment)