-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support https for both client and server #875
Conversation
Codecov ReportBase: 76.03% // Head: 76.15% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #875 +/- ##
==========================================
+ Coverage 76.03% 76.15% +0.12%
==========================================
Files 110 110
Lines 12741 12741
==========================================
+ Hits 9687 9703 +16
+ Misses 2507 2496 -11
+ Partials 547 542 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Co-authored-by: Bomin Zhang <localvar@hotmail.com>
hi @samanhappy , I was thinking of improving the user experience of to achieve this, we need the following:
the only issue is, under |
@localvar
maybe we can do a retry work for these error message, how about it? |
@samanhappy how much time does it cost? I think this is fine if it is under a few hundred milliseconds. I propose to try HTTP first, and if we got 400, then try HTTPS. |
@localvar it should be quick because there's only a network overhead without business logic, how about this flow:
|
this is fine, but please change the option name |
Resolve #60