-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core updates + Migrate to AndroidX + targetSdkVersion 29 #7
Open
qwert2603
wants to merge
121
commits into
eastbanctechru:master
Choose a base branch
from
qwert2603:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
override all setContents methods and bind butterKnife See merge request !1
double-param-navigation See merge request !2
2) add "onDestroyPresenter" callback 3) keep presenter's state model when MvpView is recreated 4) bugfix for destroing fragment presenters 5) refactor (de)serialize method of the presenter
rename every public Mvp* class to Reamp* (excluding MvpDelegate) See merge request !5
… merge_from_github # Conflicts: # CHANGELOG # README.md # build.gradle # reamplib/build.gradle # reamplib/src/main/java/etr/android/reamp/mvp/PresenterManager.java # reamplib/src/main/java/etr/android/reamp/mvp/ReampAppCompatActivity.java # reamplib/src/main/java/etr/android/reamp/mvp/ReampCallbacks.java # reamplib/src/main/java/etr/android/reamp/mvp/ReampFragment.java # reamplib/src/main/java/etr/android/reamp/mvp/ReampStrategy.java # reamplib/src/main/res/values/strings.xml # rxstatemodel/build.gradle # sample/build.gradle # sample/src/main/AndroidManifest.xml # sample/src/main/java/example/reamp/App.java # sample/src/main/java/example/reamp/WelcomeActivity.java # sample/src/main/res/layout/activity_welcome.xml # sample/src/main/res/values/strings.xml # sample/src/test/java/example/reamp/login/LoginPresenterTest.java # settings.gradle
… view calls getPresenter() after onDestroy. Log error in such cases
…droid dependencies
* add EmptyAction for Action without Args * Action's value now must be @nonnull * deprecate ReampPresenter#onResult(int requestCode, int resultCode, Intent data) * example of unit test for presenter (OnePresenterTest.java)
Merge from github See merge request Android/reamp!8
Update 2020 04 See merge request Android/reamp!9
Android x See merge request Android/reamp!10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.