Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Spot to Add Pictures + a Notes Section #141

Closed
davidvel25 opened this issue May 2, 2021 · 9 comments · Fixed by #318
Closed

Add a Spot to Add Pictures + a Notes Section #141

davidvel25 opened this issue May 2, 2021 · 9 comments · Fixed by #318
Labels
enhancement New feature or request good first issue Good for newcomers ui Issues related to UI

Comments

@davidvel25
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
I really like using this community service tracker as my UNIVERSAL tracker. It can store as many events as needed, and it doesn't reset after the school year ends. It would be great if you could add a section when submitting community service hours to allow pictures to be attached since most community service-based clubs ask for proof by picture. I can store the pictures in this community service tracker until I need to retrieve them and use them, and this website would be a great place to store these pictures in an organized manner.

Describe the solution you'd like
Somewhere on the EHS Community Service tracker, such as below the "Contact Phone Number" Section OR beside the "Date" section, you could add an "Attach a File" Button, which the user can click to add up to 5 images related to that community service event as a PDF, DOCX, PNG, JPEG, or GIF that they can upload. Please make sure that once the pictures have been uploaded, the order of the pictures can be re-arranged so that the user can sort the order of the pictures by importance/what they want their community service officer to view first. Also, the option to delete pictures would also be great in case the user uploads the wrong file on accident (Sometimes some community service trackers don't allow the user to modify the uploads such as delete, sorting, adding more pictures once the user hits "Submit" so flexibility would be appreciated).

Describe alternatives you've considered
Adding a Notes Section where the user can type out notes regarding the service they contributed. For example,
"Did Community Service at {insert location here} with {insert friend's name here} and it was great!" and then in the notes section, the user can paste a OneDrive link to their pictures.

^^^ If the "Attach a File" feature is a plausible solution that isn't too much of a hassle to implement, this "Notes" section where the User can add notes regarding the community service opportunity would also be an excellent thing to add as well.

Additional context
I have attached a screenshot to show where the placement of these features would look like:

2021-05-01 18_13_00-Window

Xr1cak1

@theTisch21 theTisch21 self-assigned this May 2, 2021
@theTisch21
Copy link
Member

This is a good idea. I'm not sure how we would get the files into Firebase, but the notes section should be easy to implement. I'll do some testing on my fork https://github.com/thetisch21/community-service-tracker, under the branch notes-and-files

@theTisch21 theTisch21 added the enhancement New feature or request label May 2, 2021
@hazel-sudz
Copy link
Member

hazel-sudz commented May 2, 2021

@theTisch21 the proper way would be to store images in firebase storage (basically just glorified google cloud storage) and then save the links to the images in the firestore database.

A lazy way to do it (although honestly valid given the scale) would be to just base64 the images and store them as text in the database (about 30-40% overhead with base64).

@theTisch21
Copy link
Member

@daniel-sudz I'll test both options. Is there a way to run Firebase locally? Or to create a test instance in the cloud? I don't want to mess with the production database for something like this.

@hazel-sudz
Copy link
Member

@theTisch21 your easiest option would be to open your own firebase project. You should be able to have access to the free-tiere for firestore/storage without having to enable billing (although you do for cloud functions).

There is an emulator (https://firebase.google.com/docs/emulator-suite) but it currently does not support firebase storage.

@hazel-sudz
Copy link
Member

Reference for future:
Keep costs low by setting cache control to infinity (seems like this a per storage bucket attribute)
https://cloud.google.com/storage/docs/viewing-editing-metadata#edit

API reference: https://cloud.google.com/storage/docs/viewing-editing-metadata#edit

@theTisch21 @davidvel25 @Zjjc123 Could we get some more opinions from inside Key Club asking if this is something that other people want?

@theTisch21
Copy link
Member

@daniel-sudz I just asked everyone

@theTisch21
Copy link
Member

theTisch21 commented May 5, 2021

If you are here from my post on teams, please "like" this comment if you are interested in this feature
There are currently 13 "likes" on teams
Edit: This looks like it would be a popular feature! I'll start working on it.

@theTisch21
Copy link
Member

Here's a PR for a "notes" section: #169

@theTisch21 theTisch21 added the ui Issues related to UI label May 18, 2021
@theTisch21 theTisch21 removed their assignment Sep 24, 2021
@theTisch21 theTisch21 added the good first issue Good for newcomers label Oct 11, 2021
@hazel-sudz
Copy link
Member

Screen.Recording.2023-03-28.at.11.41.33.PM.mp4

@davidvel25 @theTisch21 lol it's been 2 years but here it is ig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers ui Issues related to UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants