Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up functions #168

Merged
merged 2 commits into from
May 6, 2021
Merged

Clean up functions #168

merged 2 commits into from
May 6, 2021

Conversation

hazel-sudz
Copy link
Member

@hazel-sudz hazel-sudz commented May 5, 2021 •
edited
Loading

  1. Split index.ts into backup.ts and cache.ts
  2. Move backups into seperate storage bucked so that its lifecycle rules won't apply to a potential pictures bucket (30 days retention)
  3. Re-write all imports with esm syntax for typescript
  4. Update packages for new types and fix vulnerabilities

@netlify
Copy link

netlify bot commented May 5, 2021 •
edited
Loading

This link represents the deploy preview for this given pr.

Building with commit b7af7e0

https://app.netlify.com/sites/ehs-service/deploys/609326ae4a74df000748037b

@hazel-sudz hazel-sudz marked this pull request as ready for review May 5, 2021 23:17
@hazel-sudz hazel-sudz requested a review from Zjjc123 as a code owner May 5, 2021 23:17
@hazel-sudz hazel-sudz requested a review from theTisch21 May 5, 2021 23:18
theTisch21
theTisch21 approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@theTisch21 theTisch21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good!

@theTisch21 theTisch21 merged commit 8cadc4f into master May 6, 2021
@theTisch21 theTisch21 deleted the cleanup-functions branch May 6, 2021 04:07
@Zjjc123 Zjjc123 added the format Clean up code, format, and/or refactor label May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zjjc123 Zjjc123 Zjjc123 approved these changes

@theTisch21 theTisch21 theTisch21 approved these changes

Assignees
No one assigned
Labels
format Clean up code, format, and/or refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hazel-sudz @theTisch21 @Zjjc123