Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

derive easyblock for iccifort only from icc easyblock (not ifort) #1899

Merged
merged 2 commits into from
Jan 2, 2020

Conversation

bartoldeman
Copy link
Contributor

EB_ifort is problematic since the module guesses include
$EBROOTICCIFORT/include which should not be added to CPATH
for a joint icc/ifort installation.

EB_ifort is problematic since the module guesses include
$EBROOTICCIFORT/include which should not be added to CPATH
for a joint icc/ifort installation.
@boegel boegel changed the title Derive EB_iccifort from EB_icc only. derive easyblock for iccifort only from icc easyblock (not ifort) Dec 30, 2019
@boegel boegel added this to the release after 4.1.1 (4.1.2?) milestone Dec 30, 2019
@boegel
Copy link
Member

boegel commented Dec 30, 2019

@bartoldeman There's a hard call to EB_ifort.sanity_check_step too, which is broken now:

ERROR: Traceback (most recent call last):
  File "/lib/python2.7/site-packages/easybuild_framework-4.1.1.dev0-py2.7.egg/easybuild/main.py", line 113, in build_and_install_software
    (ec_res['success'], app_log, err) = build_and_install_one(ec, init_env)
  File "/lib/python2.7/site-packages/easybuild_framework-4.1.1.dev0-py2.7.egg/easybuild/framework/easyblock.py", line 3092, in build_and_install_one
    result = app.run_all_steps(run_test_cases=run_test_cases)
  File "/lib/python2.7/site-packages/easybuild_framework-4.1.1.dev0-py2.7.egg/easybuild/framework/easyblock.py", line 3000, in run_all_steps
    self.run_step(step_name, step_methods)
  File "/lib/python2.7/site-packages/easybuild_framework-4.1.1.dev0-py2.7.egg/easybuild/framework/easyblock.py", line 2870, in run_step
    step_method(self)()
  File "/tmp/eb-s08Uo0/included-easyblocks/easybuild/easyblocks/iccifort.py", line 50, in sanity_check_step
    EB_ifort.sanity_check_step(self)
TypeError: unbound method sanity_check_step() must be called with EB_ifort instance as first argument (got EB_iccifort instance instead)

@bartoldeman
Copy link
Contributor Author

Strange that that survived my testing.
Must be a difference between python2 and python3 I was not aware of yet. I'll have a look.

It's necessary to derive from EB_ifort to stay compatible with
Python 2.x.
@bartoldeman
Copy link
Contributor Author

It was indeed a difference between Python2 and 3:
https://portingguide.readthedocs.io/en/latest/core-obj-misc.html#unbound-methods

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 85333b3 into easybuilders:develop Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants