Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make MATLAB runtime available from MATLAB #2008

Merged
merged 2 commits into from
Apr 7, 2020
Merged

make MATLAB runtime available from MATLAB #2008

merged 2 commits into from
Apr 7, 2020

Conversation

smoors
Copy link
Contributor

@smoors smoors commented Apr 1, 2020

with this update, the MCR is no longer needed if MATLAB is installed.

@smoors smoors changed the title make MATLAB runtime available from MATLAB make MATLAB runtime available from MATLAB (WIP) Apr 2, 2020
@smoors smoors mentioned this pull request Apr 2, 2020
Merged
@smoors smoors changed the title make MATLAB runtime available from MATLAB (WIP) make MATLAB runtime available from MATLAB Apr 2, 2020
@akesandgren
Copy link
Contributor

I assume you have tested this?

And sigh.... why can't they learn how to properly package things.... libraries in bin... the stupidity

@smoors
Copy link
Contributor Author

smoors commented Apr 3, 2020

@akesandgren yes, I tested it for 2017a, 2019a, and 2019b.
the test report in easybuilders/easybuild-easyconfigs#10301 was done with this easyblock.

Micket
Micket approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket added this to the next release (4.2.0) milestone Apr 7, 2020
@Micket Micket merged commit aed5d2e into easybuilders:develop Apr 7, 2020
@3rdcycle 3rdcycle mentioned this pull request Jul 19, 2023
Closed
@ocaisa ocaisa mentioned this pull request Aug 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Micket Micket Micket approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@smoors @akesandgren @Micket