-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update ABAQUS easyblock to support installation of v2020 #2034
Conversation
I've uploaded https://gist.github.com/branfosj/f0bfa2410f7279e5c2d0dfb58bc3c2e6 which is the output of the ABAQUS installer for one of my test runs. This means that we have a record of the path through the installer. |
Test report using the latest version of the block is at easybuilders/easybuild-easyconfigs#10423 (comment) I've also tested this with ABAQUS 2017 and that installs fine. I've not got the sources for 2018 or 2019 so I cannot test those. |
close/re-open to refresh CI (we now have a stricter code style check) |
@branfosj This breaks the installation of It looks like it chokes on this now, not being able to answer this question:
|
easybuild/easyblocks/a/abaqus.py
Outdated
r"Please choose an action:": '1', | ||
|
||
# Continue | ||
nextstr: '', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@branfosj One thing to be aware of here is that there's no order over these patterns (because it's a dict
value).
So if the pattern in nextstr
is matched, you won't match any other more specific patterns that also include the nextstr
pattern...
What is the status of this PR ? |
It works for me for both ABAQUS 2017 and 2020 (these are the versions I have sources for). However, it is broken installing ABAQUS 2018 hotfix 1806 (and maybe other versions). The broken installs may be because of the issue in #2034 (comment) Currently I do not have the time to investigate further. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@branfosj I think we need to switch to using an ordered dictionary to ensure that the question patterns are considered in order.
I did that in bear-rsg#91, and it fixes the issue where the installation of older ABAQUS got broken...
use OrderedDict to std_qa in ABAQUS easyblock
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 5 out of 5 (5 easyconfigs in total) |
There are some differences to where some items end up being installed. The items that were in
sim
are now incae
and I could not see a way to separate them from the items that are installed intocae
. (This is compared to an ABAQUS 2017 installation - we do not have a newer version installed.)