-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raise error when unknown 'install_type' is used in Tarball easyblock + fix log messages #2049
raise error when unknown 'install_type' is used in Tarball easyblock + fix log messages #2049
Conversation
…+ fix log messages
Testing with easybuilders/easybuild-framework#3310 Successful test using Log of the build: https://gist.github.com/lexming/8d2037338c4b365dcbae58b83c3484de |
Testing with easybuilders/easybuild-framework#3310 FAILED test using Log of the build: https://gist.github.com/lexming/156e9ab54a373612a5142d49c66f1480 The reason for the failure is that there is a broken symlink at |
@lexming That use case should be fixed now in easybuilders/easybuild-framework#3310 (also covered by the enhanced tests) |
Testing with easybuilders/easybuild-framework#3310 (easybuilders/easybuild-framework@3c80fef) SUCCESSFUL test with SUCCESSFUL test with SUCCESSFUL test with SUCCESSFUL test without |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I would just remove the Ignoring
part from the error message as it is no longer the case.
Co-authored-by: Alex Domingo <alex.domingo.toro@vub.be>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Going in, thanks for the fixes @boegel ! |
@lexming follow-up for #1989
we shouldn't silently ignore the use of an unknown '
install_type
' value, it should raise an error insteadorder of name/dir in log message is fixed, was:
now: