Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly determine path to active binutils in TensorFlow easyblock #2218

Merged
merged 5 commits into from
Sep 4, 2023
Merged

correctly determine path to active binutils in TensorFlow easyblock #2218

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0d0b067
support using system binutils in TensorFlow easyblock, taking into ac…
boegel Oct 31, 2020
f939eea
determine path to binutils location via which('ld'), so ld wrapper sc…
boegel Nov 2, 2020
3f18097
remove superfluous/confusing log messages
boegel Nov 2, 2020
815ea59
Merge branch 'develop' into tensorflow_binutils_fix
boegel Apr 11, 2021
7f61b03
Merge branch 'develop' into tensorflow_binutils_fix
boegel Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions easybuild/easyblocks/t/tensorflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,10 +421,12 @@ def setup_build_dirs(self):
def configure_step(self):
"""Custom configuration procedure for TensorFlow."""

binutils_root = get_software_root('binutils')
if not binutils_root:
raise EasyBuildError("Failed to determine installation prefix for binutils")
self.binutils_bin_path = os.path.join(binutils_root, 'bin')
# determine location where binutils' ld command is installed
# note that this may be an RPATH wrapper script (when EasyBuild is configured with --rpath)
ocaisa marked this conversation as resolved.
Show resolved Hide resolved
ld_path = which('ld')
self.log.info("Found ld at %s", ld_path)
boegel marked this conversation as resolved.
Show resolved Hide resolved
self.binutils_bin_path = os.path.dirname(ld_path)
self.log.info("Assuming that all binutils tools are located at %s", self.binutils_bin_path)
boegel marked this conversation as resolved.
Show resolved Hide resolved

# filter out paths from CPATH and LIBRARY_PATH. This is needed since bazel will pull some dependencies that
# might conflict with dependencies on the system and/or installed with EB. For example: protobuf
Expand Down