Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create less temporary directories for TensorFlow by (only) using --output_user_root #2293

Merged
merged 2 commits into from
Feb 2, 2021
Merged

create less temporary directories for TensorFlow by (only) using --output_user_root #2293

merged 2 commits into from
Feb 2, 2021

Conversation

Flamefire
Copy link
Contributor

The only thing needed is output_user_root which acts as a prefix for everything used by Bazel
Particularly TEST_TMPDIR mustn't be set as that changes Bazel internal state

@Flamefire Flamefire mentioned this pull request Dec 22, 2020
Merged
6 tasks
@boegel boegel changed the title Create and set less folders for TensorFlow create less temporary directories for TensorFlow by (only) using --output_user_root Dec 31, 2020
@boegel boegel added this to the next release (4.3.3?) milestone Dec 31, 2020
@boegel boegel added the change label Dec 31, 2020
@Flamefire Flamefire mentioned this pull request Jan 19, 2021
Merged
1 task
@Flamefire
Create and set less folders for TensorFlow
02d73b0 
The only thing needed is output_user_root which acts as a prefix for
everything used by Bazel
Particlarly TEST_TMPDIR mustn't be set as that changes Bazel internal state
@Flamefire
Adapt configure patch for TF >= 1.12
9b33659
@Flamefire Flamefire mentioned this pull request Jan 25, 2021
Merged
@boegel
Copy link
Member

boegel commented Jan 31, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS TensorFlow-1.14.0-foss-2019a-Python-3.7.2.eb
  • SUCCESS TensorFlow-1.15.0-foss-2019b-Python-3.7.4.eb
  • SUCCESS TensorFlow-1.15.2-foss-2019b-Python-3.7.4.eb
  • SUCCESS TensorFlow-2.1.0-foss-2019b-Python-3.7.4.eb
  • SUCCESS TensorFlow-2.2.0-foss-2019b-Python-3.7.4.eb
  • SUCCESS TensorFlow-2.3.1-foss-2019b-Python-3.7.4.eb
  • SUCCESS TensorFlow-2.3.1-foss-2020a-Python-3.8.2.eb

Build succeeded for 7 out of 7 (7 easyconfigs in total)
node3147.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/0ac6f0eb05eaf5c85c29856d72e0b70e for a full test report.

@boegel
Copy link
Member

boegel commented Jan 31, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS TensorFlow-1.15.2-fosscuda-2019b-Python-3.7.4.eb
  • SUCCESS TensorFlow-2.0.1-fosscuda-2019b-Python-3.7.4.eb
  • SUCCESS TensorFlow-2.2.0-foss-2019b-Python-3.7.4.eb
  • SUCCESS TensorFlow-2.2.0-fosscuda-2019b-Python-3.7.4.eb
  • SUCCESS TensorFlow-2.3.1-foss-2020a-Python-3.8.2.eb
  • SUCCESS TensorFlow-2.3.1-fosscuda-2019b-Python-3.7.4.eb

Build succeeded for 6 out of 6 (6 easyconfigs in total)
node2611.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/e4fc8aba31eff4a556cebfc344f893eb for a full test report.

boegel
boegel approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 236d273 into easybuilders:develop Feb 2, 2021
@Flamefire Flamefire deleted the tf_reduce_dirs branch February 2, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
change
Projects
None yet
Milestone
4.3.3
Development

Successfully merging this pull request may close these issues.
2 participants
@Flamefire @boegel