-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add custom easyblock to support installation of new Intel compilers (v2021.x, oneAPI) #2305
Conversation
…specified easyblock for bundle component
…el-compilers easyblock
8719324
to
14e631e
Compare
…g for accepted EULA
@rscohn2 Any feedback on this? |
It looks good. Where is the code that constructs the URL for downloads? |
@rscohn2 You can find the URL for downloading in https://github.com/easybuilders/easybuild-easyconfigs/pull/11982/files |
Can I do anything to help this getting forward? |
If you're up for it, you could look into the necessary changes w.r.t. redefining One way could be to adding You can test using I hope to pick up on this again myself soon, but finding time for it has not been easy in recent weeks... 😅 |
Okay, not sure I have the necessary knowledge yet, but I'll have a look. Regarding the variable, subprocess.Popen() actually allows passing an env, which we could just copy from os.environ. Then we dont run any risk of modifying the live env. Maybe that would be a sensible addition to run_cmd? I'll try prefixing the command as well though. What I don't know, does that actually work in all shells, i.e. tscsh or ksh, or are we always in bash (didnt find it directly)? |
@boegel Just a short ping to ask which direction you think makes more sense. |
@scroogie |
And only clean up $HOME/intel if it exists
Only redefine HOME when it is required
Don't merge this just yet, may need some more love since to get the 2021.1.2 version of the compilers you need to install the HPC base kit + additional updates for C/C++ and Fortran compilers; see https://community.intel.com/t5/Intel-Fortran-Compiler/Announcing-Intel-Fortran-Compiler-Patch-Release-2021-1-2-Answers/m-p/1240262#M153503... |
…ake sure version is correct
…releases for Intel oneAPI compilers
@ocaisa I think this is good to go now... Works fine with easybuilders/easybuild-easyconfigs#11982, and I'll also upload a test report with older versions of the Intel tools, to confirm nothing got broken with the changes being made here... |
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 5 out of 5 (5 easyconfigs in total) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 4 out of 4 (4 easyconfigs in total) |
IntelBase
to implement installation procedure for 2021.x versions of Intel toolsintel-compilers
, to be used with Intel oneAPI HPC Base toolkit v2021 & newerBundle
that I hit when working on thisrequires
add support for --accept-eula configuration option + 'accept_eula' easyconfig parameter easybuild-framework#3535(support for--accept-eula
)add support for specifying custom name to use when checking accepted EULA easybuild-framework#3546to allow using custom name when callingcheck_accepted_eula