Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance cuDNN and CUDA easyblocks to support aarch64 #2356

Merged
merged 8 commits into from
Apr 6, 2021
Merged

enhance cuDNN and CUDA easyblocks to support aarch64 #2356

merged 8 commits into from
Apr 6, 2021

Conversation

robert-mijakovic
Copy link

Adds armsbsa in cuDNN easyblock.

@branfosj branfosj mentioned this pull request Mar 10, 2021
Merged
@robert-mijakovic robert-mijakovic changed the title cuDNN easyblock to allow for armsbsa (AARCH64). cuDNN and Java easyblocks extended to allow AARCH64, armsbsa and aarch64, respectively. Mar 11, 2021
@robert-mijakovic robert-mijakovic changed the title cuDNN and Java easyblocks extended to allow AARCH64, armsbsa and aarch64, respectively. cuDNN, CUDA, and Java easyblocks extended to allow AARCH64, through armsbsa, sbsa, and aarch64, suffixes, respectively. Mar 11, 2021
@boegel boegel added this to the 4.x milestone Mar 16, 2021
boegel
boegel requested changes Mar 16, 2021
View reviewed changes
easybuild/easyblocks/c/cuda.py Outdated Show resolved Hide resolved
easybuild/easyblocks/j/java.py Outdated Show resolved Hide resolved
easybuild/easyblocks/j/java.py Outdated Show resolved Hide resolved
@boegel boegel changed the title cuDNN, CUDA, and Java easyblocks extended to allow AARCH64, through armsbsa, sbsa, and aarch64, suffixes, respectively. enhance cuDNN, CUDA, and Java easyblocks to support aarch64 Mar 16, 2021
@boegel boegel modified the milestones: 4.x, next release (4.3.4?) Mar 31, 2021
@boegel boegel changed the title enhance cuDNN, CUDA, and Java easyblocks to support aarch64 enhance cuDNN and CUDA easyblocks to support aarch64 Apr 6, 2021
boegel
boegel approved these changes Apr 6, 2021
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Apr 6, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS CUDA-11.1.1-GCC-10.2.0.eb
  • SUCCESS cuDNN-8.0.4.30-CUDA-11.1.1.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3131.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/3efeb32d8cf4a24ded0375d59c5c0d7b for a full test report.

@boegel boegel merged commit b02deab into easybuilders:develop Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocaisa ocaisa ocaisa left review comments

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@robert-mijakovic @boegel @ocaisa