-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Java wrapper support to OpenMPI #2360
base: develop
Are you sure you want to change the base?
Conversation
Test report by @ocaisa Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @ocaisa Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Easyconfig tested is a stock easyconfig with a java dep:
|
# handle Java support | ||
java = 'java' | ||
if config_opt_unused(java, enable_mpi=True): | ||
dep_root = get_software_root(java) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't get_software_root case sensitive? If so it should be ('Java') not lowercase...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ocaisa this needs a conflict resolution |
Java wrapper support is currently experimental in OpenMPI.
I've added support for the wrappers to the EasyBlock, but I don't intend to upload an easyconfig that uses them since choosing a Java version will introduces a new degree of freedom in our toolchains (and it is likely to be a very site-specific choice)