Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Java wrapper support to OpenMPI #2360

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

ocaisa
Copy link
Member

@ocaisa ocaisa commented Mar 15, 2021

Java wrapper support is currently experimental in OpenMPI.

I've added support for the wrappers to the EasyBlock, but I don't intend to upload an easyconfig that uses them since choosing a Java version will introduces a new degree of freedom in our toolchains (and it is likely to be a very site-specific choice)

@ocaisa
Copy link
Member Author

ocaisa commented Mar 15, 2021

Test report by @ocaisa

Overview of tested easyconfigs (in order)

  • SUCCESS OpenMPI-4.1.0-GCC-10.2.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz, Python 3.6.8
See https://gist.github.com/073f203db02e1cbae9f9bacfbfbb8637 for a full test report.

@ocaisa
Copy link
Member Author

ocaisa commented Mar 15, 2021

Test report by @ocaisa

Overview of tested easyconfigs (in order)

  • SUCCESS OpenMPI-4.1.0-GCC-10.2.0-java.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz, Python 3.6.8
See https://gist.github.com/e7e1a5bbe852d1be2c58518b528d4932 for a full test report.

@ocaisa
Copy link
Member Author

ocaisa commented Mar 15, 2021

Easyconfig tested is a stock easyconfig with a java dep:

[ocaisa@generoso ~]$ !diff
diff /users/ocaisa/EasyBuild_Git/easybuild-easyconfigs/easybuild/easyconfigs/o/OpenMPI/OpenMPI-4.1.0-GCC-10.2.0.eb ./OpenMPI-4.1.0-GCC-10.2.0-java.eb 
2a3
> versionsuffix = '-java'
23a25
>     ('Java', '11', '', True),

@boegel boegel added this to the 4.x milestone Mar 16, 2021
# handle Java support
java = 'java'
if config_opt_unused(java, enable_mpi=True):
dep_root = get_software_root(java)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't get_software_root case sensitive? If so it should be ('Java') not lowercase...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akesandgren
Copy link
Contributor

@ocaisa this needs a conflict resolution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants