Clean up installation of Tkinter #2509
Conversation
Avoids a useless PYTHONPATH of "easybuild/python"
Also set the path in prepare_step
|
Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 33 out of 35 (9 easyconfigs in total) |
|
Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
|
Test report by @ocaisa Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (2 easyconfigs in total) |
|
Test report by @ocaisa Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (2 easyconfigs in total) |
| easybuild_subdir = log_path() | ||
| self.pythonpath = os.path.join(easybuild_subdir, 'python') | ||
| # Used for EBPYTHONPREFIXES handler script | ||
| self.pythonpath = os.path.join(log_path(), 'python') |
There was a problem hiding this comment.
@ocaisa Setting this always here (instead of conditionally None) provides most of backwards compat. However there is a minor change especially with checking (now consistently) for self.cfg.get('ebpythonprefixes')
This allows derived easyblocks to overwrite this value if they need to instead of overwriting it in prepare_step
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 6 out of 6 (6 easyconfigs in total) |
Tkinter adds a non-existing path
easybuild/pythonto PYTHONPATH, which is a bug.In the process I'v also done some cleanup:
site-packagesespecially to work with EBPYTHONPREFIXES and hence virtualenvs. Moved.get_tkinter_so_basenameto explicitely ask for getting from our installdir or from python