new easyblock for darshan #2548
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
|
|
||
| #txt += self.module_generator.prepend_paths('PE_PKGCONFIG_LIBS', 'darshan-util', expand_relpaths=False) | ||
| #txt += self.module_generator.prepend_paths('PE_PKGCONFIG_PRODUCTS', 'DARSHAN', expand_relpaths=False) | ||
| #txt += self.module_generator.prepend_paths('DARSHAN_PKGCONFIG_LIBS', 'darshan', expand_relpaths=False) |
There was a problem hiding this comment.
block comment should start with '# '
| txt += self.module_generator.prepend_paths('PE_PKGCONFIG_LIBS', 'darshan-runtime', expand_relpaths=False) | ||
|
|
||
| #txt += self.module_generator.prepend_paths('PE_PKGCONFIG_LIBS', 'darshan-util', expand_relpaths=False) | ||
| #txt += self.module_generator.prepend_paths('PE_PKGCONFIG_PRODUCTS', 'DARSHAN', expand_relpaths=False) |
There was a problem hiding this comment.
block comment should start with '# '
| if self.toolchain.toolchain_family() == toolchain.CRAYPE: | ||
| txt += self.module_generator.prepend_paths('PE_PKGCONFIG_LIBS', 'darshan-runtime', expand_relpaths=False) | ||
|
|
||
| #txt += self.module_generator.prepend_paths('PE_PKGCONFIG_LIBS', 'darshan-util', expand_relpaths=False) |
There was a problem hiding this comment.
block comment should start with '# '
| super(EB_Darshan, self).sanity_check_step(custom_paths) | ||
|
|
||
|
|
||
| def make_module_extra(self, *args, **kwargs): |
| 'bin/dxt_analyzer.py', | ||
| 'lib/libdarshan-util.a', | ||
| ], | ||
| 'dirs' : [ 'bin', 'lib', 'share' ], |
There was a problem hiding this comment.
whitespace after '['
whitespace before ':'
whitespace before ']'
|
|
||
| # environment variable may be defined but empty | ||
| if os.getenv('MPICC', None) is None: | ||
| raise EasyBuildError("Required environment variable %s not found (no toolchain used?).", envvar) |
| extra_vars = { | ||
| 'mem_align': ["8", "determines if the buffer for a read or write operation is aligned in memory.", CUSTOM], | ||
| 'logpath_env': ["DARSHAN_LOG_DIR_PATH", "specifies an environment variable to use to determine the log path at run time", CUSTOM], | ||
| 'jobid_env': ['SLURM_JOB_ID', "specifies the environment variable that Darshan should check to determine the jobid of a job", CUSTOM], |
There was a problem hiding this comment.
line too long (148 > 120 characters)
| def extra_options(): | ||
| extra_vars = { | ||
| 'mem_align': ["8", "determines if the buffer for a read or write operation is aligned in memory.", CUSTOM], | ||
| 'logpath_env': ["DARSHAN_LOG_DIR_PATH", "specifies an environment variable to use to determine the log path at run time", CUSTOM], |
There was a problem hiding this comment.
line too long (142 > 120 characters)
| from easybuild.easyblocks.generic.configuremake import ConfigureMake | ||
| from easybuild.framework.easyconfig import CUSTOM | ||
| from easybuild.tools.build_log import EasyBuildError | ||
| from easybuild.tools.config import get_module_syntax |
There was a problem hiding this comment.
'easybuild.tools.config.get_module_syntax' imported but unused
| """ | ||
|
|
||
| import os | ||
| import shutil |
| # along with EasyBuild. If not, see <http://www.gnu.org/licenses/>. | ||
| ## | ||
| """ | ||
| EasyBuild support for building and installing HPL, implemented as an easyblock |
There was a problem hiding this comment.
@satishskamath This is clearly incorrect, please fix (replace HPL with Darshan), and mention yourself + your affiliation as an author
|
@satishskamath Are you up for cleaning up the reported code style issues? |
Hi @boegel , I am up for making the changes but am currently on vacation until Sept 27th. Can I take make the changes right after my vacation? |
Of course, no rush! Do let us know if you need any help with this... |
(created using
eb --new-pr)