Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set wm_* class variables in OpenFOAM easyblock constructor (to fix --sanity-check-only) #2616

Merged
merged 5 commits into from
Dec 9, 2021
Merged

set wm_* class variables in OpenFOAM easyblock constructor (to fix --sanity-check-only) #2616

merged 5 commits into from
Dec 9, 2021

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Nov 9, 2021 •
edited
Loading

(created using eb --new-pr)

  • set wm_compiler and wm_mplib when running --sanity-check-only

This will still fail when running --sanity-check-only because of easybuilders/easybuild-framework#3895

(This originally included MPI oversupscritpion for the sanity check, but I've removed that as we'll look at a different method for that.)

@branfosj
set wm_* vars when running sanity-check-only and oversubscribe parall…
129ff61 
…elism to all for <6 cores in the sanity check
@branfosj branfosj added this to the next release (4.5.1?) milestone Nov 9, 2021
@branfosj branfosj mentioned this pull request Nov 9, 2021
Merged
@branfosj branfosj changed the title set wm_* vars when running sanity-check-only and oversubscribe parallelism to all for <6 cores in the sanity check set wm_* vars when running sanity-check-only Nov 9, 2021
@boegel boegel changed the title set wm_* vars when running sanity-check-only set wm_* class variable in OpenFOAM easyblock when using --sanity-check-only Nov 10, 2021
@branfosj
Copy link
Member Author

branfosj commented Dec 4, 2021 •
edited
Loading

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS OpenFOAM-v2106-foss-2021a.eb
  • SUCCESS OpenFOAM-8-foss-2020b.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/8b2db4d1f7c376b8df35396c6713a07d for a full test report.

edit uses easybuilders/easybuild-framework#3900

@boegel
Copy link
Member

boegel commented Dec 9, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS OpenFOAM-v2006-foss-2020a.eb
  • SUCCESS OpenFOAM-8-foss-2020a.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
node2624.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/fafca37ccc639fc9b06fb61c2a2ecca9 for a full test report.

@easybuilders easybuilders deleted a comment from boegelbot Dec 9, 2021
@boegel
Copy link
Member

boegel commented Dec 9, 2021

@branfosj I pushed in another change to just set wm_compiler and wm_mplib in the constructor.
Works fine because the build environment doesn't need to be set up yet, and it'll result in a more correct module file when --module-only --force is used.

It does cause some trouble in the easyblock test suite though 😅

@boegel
Copy link
Member

boegel commented Dec 9, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS HEALPix-3.50-GCCcore-8.2.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2624.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/e2a4573eca51d9a437c624cc5e23410e for a full test report.

boegel
boegel approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 279ceb6 into easybuilders:develop Dec 9, 2021
@branfosj branfosj deleted the 20211109123841_new_pr_openfoam branch December 9, 2021 21:40
@boegel boegel changed the title set wm_* class variable in OpenFOAM easyblock when using --sanity-check-only set wm_* class variables in OpenFOAM easyblock constructor (to fix --sanity-check-only) Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.5.1
Development

Successfully merging this pull request may close these issues.
2 participants
@branfosj @boegel