add custom easyblock for Clang-AOMP #2617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
reviewed
Nov 13, 2021
boegel
requested changes
Nov 13, 2021
boegel
requested changes
Dec 8, 2021
There was a problem hiding this comment.
@nordmoen I've reviewed this in detail, and tweaked it a bit for a variety of reasons, please take a look at nordmoen#4
fixes, enhancements and code cleanup for custom easyblock for Clang-AOMP
… with --module-only by defining self.cuda_archs in prepare_step
boegel
requested changes
Dec 9, 2021
fix sanity check for Clang-AOMP with CUDA support + full sanity check with --module-only by defining self.cuda_archs in prepare_step
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
boegel
approved these changes
Dec 10, 2021
|
Tested with both easybuilders/easybuild-easyconfigs#14327 and a custom Thanks a lot for your efforts on this @nordmoen, it's clear that this wasn't exactly trivial... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for easybuilders/easybuild-easyconfigs#14327