-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance tbb easyblock by adding option to build Python bindings #2626
enhance tbb easyblock by adding option to build Python bindings #2626
Conversation
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 3 out of 3 (3 easyconfigs in total) |
@boegel Wait a minute, I messed up PYTHONPATH I first used set_environment to set it, which worked for sanity checks but not for epiScanPy bundle (because I was overwriting the variable, duh) - and now that I've changed it to I'll need to take a closer look tomorrow |
...duh once again 🙈 I saw a bunch of GitHub notifications and remembered I have a WIP in my terminal, nevermind :) |
Going in, thanks @zarybnicky! |
(created using
eb --new-pr
)TBB bundles a number of language bindings in the same source tree, also including make targets to build them. This PR add an
extra_option
with_python
that enables building the Python bindings. For this to be used, Python and SWIG must be in the dependency list (SWIG as a builddependency), as well as a Makefile patch - these are provided in the easyconfig.Given that the next version of TBB is implemented as a mix of CMake+Bazel (instead of Make+CMake used by TBB v.2020.3, which this PR is for), it seems that the entire easyblock will need to be rebuilt in the next update anyway.