Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance tbb easyblock by adding option to build Python bindings #2626

Merged
merged 9 commits into from
Nov 25, 2021

Conversation

zarybnicky
Copy link
Contributor

@zarybnicky zarybnicky commented Nov 25, 2021

(created using eb --new-pr)

TBB bundles a number of language bindings in the same source tree, also including make targets to build them. This PR add an extra_option with_python that enables building the Python bindings. For this to be used, Python and SWIG must be in the dependency list (SWIG as a builddependency), as well as a Makefile patch - these are provided in the easyconfig.

Given that the next version of TBB is implemented as a mix of CMake+Bazel (instead of Make+CMake used by TBB v.2020.3, which this PR is for), it seems that the entire easyblock will need to be rebuilt in the next update anyway.

@boegel boegel added this to the next release (4.5.1?) milestone Nov 25, 2021
easybuild/easyblocks/t/tbb.py Outdated Show resolved Hide resolved
easybuild/easyblocks/t/tbb.py Outdated Show resolved Hide resolved
easybuild/easyblocks/t/tbb.py Show resolved Hide resolved
@boegel boegel changed the title add option to build Python bindings of TBB enhance tbb easyblock by adding option to build Python bindings Nov 25, 2021
easybuild/easyblocks/t/tbb.py Outdated Show resolved Hide resolved
@boegel
Copy link
Member

boegel commented Nov 25, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS tbb-2019_U4-GCCcore-8.2.0.eb
  • SUCCESS tbb-2020.1-GCCcore-9.3.0.eb
  • SUCCESS tbb-2020.3-GCCcore-10.2.0.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
node2620.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/b23d2fc561b423c21ef47cc9f8f3567f for a full test report.

@zarybnicky
Copy link
Contributor Author

zarybnicky commented Nov 25, 2021

@boegel Wait a minute, I messed up PYTHONPATH

I first used set_environment to set it, which worked for sanity checks but not for epiScanPy bundle (because I was overwriting the variable, duh) - and now that I've changed it to prepend_paths, the epiScanPy sanity checks don't pass...

I'll need to take a closer look tomorrow

@zarybnicky
Copy link
Contributor Author

...duh once again 🙈 I saw a bunch of GitHub notifications and remembered I have a WIP in my terminal, nevermind :)

@boegel
Copy link
Member

boegel commented Nov 25, 2021

Going in, thanks @zarybnicky!

@boegel boegel merged commit f15070e into easybuilders:develop Nov 25, 2021
@zarybnicky zarybnicky deleted the 20211125150126_new_pr_tbb branch November 26, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants