-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix installing of Clang with RPATH linking #2799
Conversation
…t is printed in the warning. It now shows the amount of failures per test suite, as well as the total number of tests in those failing test suite. This should help interpret if 'a lot' of tests are failing, or if it is a neglible amount
…5106 . Testing is ongoing.
With this change, wrappers are correctly created for
Compiler identification by
However, I also see:
That seems weird... and indeed, this build resulted in an error:
As we can see, Looking at the same configure (of stage 2) for a build that did not use the
This build succesfully completes (but then errors out in the So... why does insertion of the |
Ah,
I'm not sure why, but for some reason Question is: who sets the And then a follow up question: how should we prevent that? Can we prevent |
…us cmake configure tests to fail. The unused command line arguments are the -Wl,-rpath commands added by the RPATH wrapper. We suppress those by adding -Wnounused-command-line-argument
Adding Now, however, we still hit a few issues at the end of the sanity check: one
Clearly, |
The missing files seem to be because
which comes from here It's a bit odd, because checking the
Which in turn does contain
Is something wrong with the Cmake logic in finding
The advantage of option 1 is that it is just a change to the configure line, and doesn't require messing with the source code. Probably, that makes it easier to maintain, so I'll try that first. |
I can confirm that adding
Resolves the issue of the missing *.bc files. I also see now in the configure:
As expected. The only remaining issue is
However, |
…hen --rpath is used. Also, put more clear comments
snap Removed test report failure because I forgot to include the framework change from easybuilders/easybuild-framework#4088 |
1 similar comment
snap Removed test report failure because I forgot to include the framework change from easybuilders/easybuild-framework#4088 |
Test report by @casparvl Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @casparvl Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @casparvl Overview of tested easyconfigs (in order)
Build succeeded for 0 out of 1 (1 easyconfigs in total) |
Hm, that error on
Anyway, not something to resolve in this PR... |
Test report by @casparvl Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requested changes done in casparvl#3
…PATH, import Clang on top
always use full path to clang/clang++ in staged build, only restore $PATH, import Clang on top
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 4 out of 4 (4 easyconfigs in total) |
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (2 easyconfigs in total) |
Test report by @casparvl Overview of tested easyconfigs (in order)
Build succeeded for 0 out of 1 (1 easyconfigs in total) |
Test report by @casparvl Overview of tested easyconfigs (in order)
Build succeeded for 0 out of 1 (1 easyconfigs in total) |
@boegel you did not get failures, because you're actually not building with Actually, you're PR casparvl#3 broke things again. To recap: My original approach
*Your approach from casparvl#3 *
The issue is that the call to
I'll revert your change, go back to my general approach as outlined above, but cherry pick some of the nice features of your change (e.g. selectively restore |
…e PATH, so put the lines back that add the original compilers to PATH
Test report by @casparvl Overview of tested easyconfigs (in order)
Build succeeded for 0 out of 1 (1 easyconfigs in total) |
…y-paste mistake from when I still used the full environment instead of just the PATH
Test report by @casparvl Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @casparvl Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 4 out of 4 (4 easyconfigs in total) edit: without |
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 4 out of 4 (4 easyconfigs in total) edit: with |
…tage 1 and 2 compilers on the PATH
This is a first attempt at fixing easybuilders/easybuild-easyconfigs#15106
It requires this small framework change easybuilders/easybuild-framework#4088