Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance EasyBuildMeta easyblock: auto-enable installing with pip + fix setup.py of easyconfigs package so installation with setuptools >= 61.0 works #2805

Merged
merged 5 commits into from
Oct 19, 2022
Merged

enhance EasyBuildMeta easyblock: auto-enable installing with pip + fix setup.py of easyconfigs package so installation with setuptools >= 61.0 works #2805

merged 5 commits into from
Oct 19, 2022

Conversation

boegel
Copy link
Member

@boegel boegel commented Oct 17, 2022

cfr. easybuilders/easybuild-easyconfigs#15206

probably fixes easybuilders/easybuild#817

definitely fixes problems reported in EESSI/software-layer#191

boegel added 2 commits October 17, 2022 22:21
@boegel
enhance EasyBuildMeta easyblock to auto-enable installing with pip ra…
7e08937 
…ther than 'setup.py install' when using Python >= 3.6 and if pip >= 21.0 is available
@boegel
enhance EasyBuildMeta easyblock to fix easybuild-easyconfigs's setup.…
fd77f29 
…py so installation with setuptools >= 61.0 works
@boegel boegel added bug fix EESSI Related to EESSI project labels Oct 17, 2022
@boegel boegel added this to the next release (4.6.2?) milestone Oct 17, 2022
This was referenced Oct 17, 2022
Closed
Closed
@boegel boegel requested a review from ocaisa October 17, 2022 20:46
@boegel
Copy link
Member Author

boegel commented Oct 17, 2022

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS EasyBuild-4.5.0.eb
  • SUCCESS EasyBuild-4.6.1.eb
  • SUCCESS networkx-2.6.3-foss-2021a.eb
  • SUCCESS matplotlib-3.5.2-intel-2022a.eb

Build succeeded for 4 out of 4 (4 easyconfigs in total)
node3116.skitty.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/b412cb4aecd667a1eb76ab7c81035bb4 for a full test report.

ocaisa
ocaisa requested changes Oct 18, 2022
View reviewed changes
easybuild/easyblocks/e/easybuildmeta.py Outdated Show resolved Hide resolved
easybuild/easyblocks/e/easybuildmeta.py Show resolved Hide resolved
@ocaisa ocaisa mentioned this pull request Oct 18, 2022
Merged
ocaisa
ocaisa approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, couple of tests and we are good to go.

@boegel
Copy link
Member Author

boegel commented Oct 19, 2022

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS EasyBuild-4.6.1.eb
  • SUCCESS EasyBuild-4.5.0.eb
  • SUCCESS EasyBuild-4.0.0.eb
  • SUCCESS networkx-2.6.3-foss-2021a.eb
  • SUCCESS matplotlib-3.5.2-intel-2022a.eb

Build succeeded for 5 out of 5 (5 easyconfigs in total)
node3116.skitty.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/7175bb0c2764fbfa3fda51b7d1ea612b for a full test report.

@ocaisa ocaisa merged commit 574e14e into easybuilders:develop Oct 19, 2022
@boegel boegel deleted the easybuild_pip branch October 19, 2022 13:59
@boegel boegel mentioned this pull request Nov 2, 2022
Open
@anselmicz anselmicz mentioned this pull request Nov 26, 2022
Closed
@boegel boegel mentioned this pull request Jan 20, 2023
Closed
@boegel
Copy link
Member Author

boegel commented Jan 20, 2023

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS EasyBuild-4.7.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3702.slaking.os - Linux UNKNOWN UNKNOWN, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 3.9.13
See https://gist.github.com/f33229e1079360fa6a3c610f49983066 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocaisa ocaisa ocaisa approved these changes

Assignees
No one assigned
Labels
bug fix EESSI Related to EESSI project
Projects
None yet
Milestone
4.6.2
Development

Successfully merging this pull request may close these issues.

Unable to install easybuild using the pip-easybuild
2 participants
@boegel @ocaisa