-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create $XDG_CACHE_HOME for PyTorch tests #2806
create $XDG_CACHE_HOME for PyTorch tests #2806
Conversation
The path must exist or PyTorch will show errors/warnings like: > UserWarning: Specified kernel cache directory could not be created! This disables kernel caching.
Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 0 out of 1 (1 easyconfigs in total) |
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 0 out of 1 (1 easyconfigs in total) |
I'm not sure why the 2 ECs failed for you but I'm quite certain not due to the change here which should be correct by inspection (and I guess some document may tell us that $XDG_CACHE_HOME must exist, so this fixes a bug) Especially as the test build on PPC passed I'd assume this is ok. ;-) |
@Flamefire I agree with you, but I'm being cautious here: we're very close to the next EasyBuild release, and I don't want to merge a PR last-minute which breaks the installation of PyTorch. I wouldn't expect that making sure that |
My testbuild of PyTorch-1.10.0-fosscuda-2020b.eb hangs on "python -s -c from multiprocessing.resource_tracker import main;main(26)" (for 11h then I killed it...) (with this easyblock but I do not believe that is it related) Same problem again without this change. |
Could this now be merged? |
Test report by @branfosj Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @branfosj Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to go ahead and merge this.
The failures are in tests that we've seen issues with in various PyTorch versions, so I do not think they are sufficient reason to prevent merging this.
Going in, thanks @Flamefire! |
The path must exist or PyTorch will show errors/warnings like: