Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add configure_without_installdir option to skip addition of prefix to configure command in ConfigureMake easyblock #2842

Merged
merged 2 commits into from
Dec 10, 2022
Merged

add configure_without_installdir option to skip addition of prefix to configure command in ConfigureMake easyblock #2842

merged 2 commits into from
Dec 10, 2022

Conversation

jfgrimm
Copy link
Member

@jfgrimm jfgrimm commented Dec 8, 2022 •
edited
Loading

No description provided.

@jfgrimm jfgrimm changed the title add option to skip addition of prefix to configure command in ConfigureMake easyblock add configure_no_prefix option to skip addition of prefix to configure command in ConfigureMake easyblock Dec 8, 2022
@branfosj branfosj added this to the next release (4.7.0) milestone Dec 8, 2022
@jfgrimm
rename configure_no_prefix to configure_without_installdir
6005d37 
clarify configure_without_installdir description
print warning if prefix_opt is specified with configure_without_installdir
@branfosj
Copy link
Member

branfosj commented Dec 9, 2022

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS JasPer-4.0.0-GCCcore-12.2.0.eb
  • SUCCESS expat-2.4.9-GCCcore-12.2.0.eb
  • SUCCESS ncurses-6.3-GCCcore-12.2.0.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
bear-pg0105u36b.bear.cluster - Linux RHEL 8.5, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/6f56091f84f565383380107e7a2b3ee8 for a full test report.

@branfosj branfosj merged commit c4ab58f into easybuilders:develop Dec 10, 2022
@jfgrimm jfgrimm changed the title add configure_no_prefix option to skip addition of prefix to configure command in ConfigureMake easyblock add configure_without_installdir option to skip addition of prefix to configure command in ConfigureMake easyblock Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akesandgren akesandgren akesandgren left review comments

@branfosj branfosj branfosj approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jfgrimm @branfosj @akesandgren