Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deprecation notice to RPackage extensions with relative paths in start_dir #2879

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

lexming
Copy link
Contributor

@lexming lexming commented Feb 8, 2023

Follow-up to #2867 and easybuilders/easybuild-framework#4206

As discussed in the last conf call, we will re-instate the old behaviour with a deprecation notice in case somebody upgrades their easybuild-easyblocks without upgrading easybuild-framework.

@lexming lexming added this to the next release (4.7.1?) milestone Feb 8, 2023
@lexming lexming added the change label Feb 8, 2023
@lexming lexming force-pushed the rpackage-start-dir branch from 7dde3a5 to 88e2617 Compare February 8, 2023 15:01
@lexming
Copy link
Contributor Author

lexming commented Feb 16, 2023

Example deprecation warning on old framework (<=4.7.0) for extensions using a relative start_dir:

== 2023-02-08 15:50:39,936 build_log.py:147 WARNING Deprecated functionality, will no longer work in v5.0: Found relative path in start_dir, please upgrade to easybuild-framework>=4.7.1; see http://easybuild.readthedocs.org/en/latest/Deprecated-functionality.html for more information

@boegel
Copy link
Member

boegel commented Mar 2, 2023

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS DUBStepR-1.2.0-foss-2021b-R-4.1.2.eb
  • SUCCESS inferCNV-1.3.3-foss-2021a.eb
  • SUCCESS rjags-4-13-foss-2022a-R-4.2.1.eb
  • SUCCESS scPred-1.9.2-foss-2021b-R-4.1.2.eb
  • SUCCESS SeuratDisk-0.0.0.9020-foss-2022a-R-4.2.1.eb
  • SUCCESS R-4.2.1-foss-2022a.eb
  • SUCCESS R-bundle-Bioconductor-3.15-foss-2022a-R-4.2.1.eb

Build succeeded for 7 out of 7 (7 easyconfigs in total)
node3104.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/2069fe37ae5667faf7bd7ae93c67f5df for a full test report.

@boegel boegel merged commit 3d02644 into easybuilders:develop Mar 2, 2023
@lexming lexming deleted the rpackage-start-dir branch March 2, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants