update Clang easyblock for versions >= 16 + run tests only for final stage of bootstrap build #2929
Conversation
Starting with LLVM 16, the Clang resource directory only uses the major version number, see - https://reviews.llvm.org/rGe1b88c8a09be25b86b13f98755a9bd744b4dbf14 - https://reviews.llvm.org/rG87760910a3111948fa56f2717fbf53e536893b2d
|
Test report by @SebastianAchilles Overview of tested easyconfigs (in order)
Build succeeded for 4 out of 4 (4 easyconfigs in total) |
|
Test report by @SebastianAchilles Overview of tested easyconfigs (in order)
Build succeeded for 9 out of 9 (9 easyconfigs in total) |
|
@geimer Can you briefly elaborate why running the tests for the earlier stages doesn't make much sense? |
boegel
changed the title
|
@boegel Sorry for being unresponsive. I took a couple of days off. At the end of the day, the tests are supposed to ensure that the installed software is doing "the right thing". So running them for the final stage is mandatory if tests are enabled. Now, one could argue that executing the tests also for the stage-1 and stage-2 builds of a bootstrap build may catch compiler failures early. However, compiling and running the tests two additional times also isn't for free. In fact, it takes a considerable amount of time. Thus, there is a tradeoff here. And since the probability of failure should -- at least in theory -- be rather low, the cost/benefit ratio is to my mind pretty bad. Those compute cycles should be used for something more productive, IMHO. |
|
@boegel Does that make sense? Any more feedback? |
|
@geimer Makes total sense, thanks for elaborating. I'll submit a test report too, for what it's worth, but this is good to in imho. |
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 5 out of 5 (5 easyconfigs in total) |
Fix sanity check for Clang 16+ and run tests only for final stage of bootstrap build.