Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add custom easyblock for sympy to fix issue in test step when tmpdir is a symlink #2949

Merged
merged 5 commits into from
Aug 5, 2023
Merged

add custom easyblock for sympy to fix issue in test step when tmpdir is a symlink #2949

merged 5 commits into from
Aug 5, 2023

Conversation

casparvl
Copy link
Contributor

@casparvl casparvl commented Jun 6, 2023 •
edited by boegel
Loading

(created using eb --new-pr)

see easybuilders/easybuild-easyconfigs#17593

@casparvl casparvl changed the title Fixes https://github.com/easybuilders/easybuild-easyconfigs/issues/17593 Fixes issue in sympy test step when tmpdir is a symlink Jun 6, 2023
@casparvl casparvl added this to the 4.x milestone Jun 6, 2023
branfosj
branfosj requested changes Jun 7, 2023
View reviewed changes
easybuild/easyblocks/s/sympy.py Outdated Show resolved Hide resolved
easybuild/easyblocks/s/sympy.py Show resolved Hide resolved
easybuild/easyblocks/s/sympy.py Outdated Show resolved Hide resolved
@boegel boegel modified the milestones: 4.x, next release (4.7.3?) Jun 7, 2023
@branfosj
Copy link
Member

branfosj commented Jun 8, 2023

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS sympy-1.11.1-foss-2022a.eb
  • SUCCESS sympy-1.8-foss-2021a.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0105u03a.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/60518c60e99150b327ee7027f67b1239 for a full test report.

branfosj
branfosj previously approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@casparvl I am happy with this, but can we have a test report from the system where this was failing before?

@boegel boegel changed the title Fixes issue in sympy test step when tmpdir is a symlink fix issue in sympy test step when tmpdir is a symlink Jun 20, 2023
@boegel boegel changed the title fix issue in sympy test step when tmpdir is a symlink add custom easyblock for sympy to fix issue in test step when tmpdir is a symlink Jul 5, 2023
@boegel
Copy link
Member

boegel commented Jul 5, 2023

We also need an accompanying easyconfigs PR to make the sympy easyconfigs use this custom easyblock?

@boegel boegel modified the milestones: 4.7.3, release after 4.7.3 Jul 5, 2023
@casparvl casparvl mentioned this pull request Jul 31, 2023
Merged
@casparvl
Copy link
Contributor Author

Created one just now easybuilders/easybuild-easyconfigs#18428
I'll start creating test reports later...

@casparvl casparvl mentioned this pull request Jul 31, 2023
Merged
@casparvl
Copy link
Contributor Author

casparvl commented Aug 3, 2023

@branfosj Reports are at easybuilders/easybuild-easyconfigs#18428 (comment)
That was done on the system where it was failing before, see easybuilders/easybuild-easyconfigs#17467 (comment)

boegel
boegel requested changes Aug 4, 2023
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This easyblock should also take care of the sanity check, etc., so the sympy easyconfigs can become pretty minimal.

I'm working on that, will send a PR to the branch used for this PR soon, testing first...

@boegel
enhance sympy easyblock by auto-enabling 'use_pip' & co, defining 'ru…
6dab14b 
…ntest' command, implementing custom sanity check
@boegel boegel mentioned this pull request Aug 4, 2023
Merged
@casparvl
Merge pull request #1 from boegel/20230606155011_new_pr_sympy
4ad894a 
enhance sympy easyblock by auto-enabling `use_pip` & co, defining `runtest` command, implementing custom sanity check
boegel
boegel approved these changes Aug 5, 2023
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extensively tested via easybuilders/easybuild-easyconfigs#18428, good to go, thanks @casparvl!

@boegel boegel merged commit a28659d into easybuilders:develop Aug 5, 2023
@maxim-masterov maxim-masterov mentioned this pull request Aug 22, 2023
Merged
@boegel boegel added the new label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

@branfosj branfosj branfosj left review comments

Assignees
No one assigned
Labels
bug fix new
Projects
None yet
Milestone
4.8.1
Development

Successfully merging this pull request may close these issues.
3 participants
@casparvl @branfosj @boegel