Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update TensorFlow easyblock for v2.13 since LMDB is no longer a dependency #2982

Merged
merged 3 commits into from
Aug 31, 2023
Merged

update TensorFlow easyblock for v2.13 since LMDB is no longer a dependency #2982

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5898a2e
Update TensorFlow SYSTEMLIBS for TF 2.13
Flamefire Aug 9, 2023
3b5c324
Comment why some systemlibs are unused
Flamefire Aug 15, 2023
9a74beb
fix typo in comment regarding boringssl in TensorFlow easyblock
boegel Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions easybuild/easyblocks/t/tensorflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ def is_version_ok(version_range):
('libjpeg-turbo', '2.2.0:'): 'libjpeg_turbo',
('libpng', '2.0.0:2.1.0'): 'png_archive',
('libpng', '2.1.0:'): 'png',
('LMDB', '2.0.0:'): 'lmdb',
('LMDB', '2.0.0:2.13.0'): 'lmdb',
('NASM', '2.0.0:'): 'nasm',
('nsync', '2.0.0:'): 'nsync',
('PCRE', '2.0.0:2.6.0'): 'pcre',
Expand All @@ -161,11 +161,11 @@ def is_version_ok(version_range):
# Software recognized by TF but which is always disabled (usually because no EC is known)
# Format: <TF name>: <version range>
unused_system_libs = {
'boringssl': '2.0.0:',
'boringssl': '2.0.0:', # Implied by cURL and existence of OpenSSL anywhere in the dependency chain
'com_github_googleapis_googleapis': '2.0.0:2.5.0',
'com_github_googlecloudplatform_google_cloud_cpp': '2.0.0:', # Not used due to $TF_NEED_GCP=0
'com_github_grpc_grpc': '2.2.0:',
'com_googlesource_code_re2': '2.0.0:',
'com_googlesource_code_re2': '2.0.0:', # Requires the RE2 version with Abseil (or 2023-06-01+)
'grpc': '2.0.0:2.2.0',
}
# Python packages installed as extensions or in the Python module
Expand Down Expand Up @@ -335,10 +335,10 @@ def verify_system_libs_info(self):
msg = 'Values for $TF_SYSTEM_LIBS in the TensorFlow EasyBlock are incomplete.\n'
if missing_libs:
# Libs available according to TF sources but not listed in this EasyBlock
msg += 'Missing entries for $TF_SYSTEM_LIBS: %s\n' % missing_libs
msg += 'Missing entries for $TF_SYSTEM_LIBS: %s\n' % sorted(missing_libs)
if unknown_libs:
# Libs listed in this EasyBlock but not present in the TF sources -> Removed?
msg += 'Unrecognized entries for $TF_SYSTEM_LIBS: %s\n' % unknown_libs
msg += 'Unrecognized entries for $TF_SYSTEM_LIBS: %s\n' % sorted(unknown_libs)
msg += 'The EasyBlock needs to be updated to fully work with TensorFlow version %s' % self.version
if build_option('strict') == run.ERROR:
raise EasyBuildError(msg)
Expand Down
Loading