Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace run_cmd with run_shell_cmd in custom easyblock for GCC (gcc.py) #3137

Merged
merged 1 commit into from
Feb 9, 2024
Merged

replace run_cmd with run_shell_cmd in custom easyblock for GCC (gcc.py) #3137

merged 1 commit into from
Feb 9, 2024

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Feb 1, 2024 •
edited
Loading

(created using eb --new-pr)

  • EB_GCC is used in GCCcore
  • EB_GCC is used by generic/systemcompiler.py

@branfosj branfosj changed the title replace run_cmd with run_shell_cmd in custom easyblock for gcc (gcc.py) replace run_cmd with run_shell_cmd in custom easyblock for GCC (gcc.py) Feb 1, 2024
@branfosj branfosj added change EasyBuild-5.0 EasyBuild 5.0 labels Feb 1, 2024
@branfosj branfosj added this to the 5.0 milestone Feb 1, 2024
@branfosj branfosj mentioned this pull request Feb 1, 2024
Closed
@branfosj
Copy link
Member Author

branfosj commented Feb 1, 2024

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS GCCcore-9.3.0.eb
  • SUCCESS GCCcore-10.2.0.eb
  • SUCCESS GCCcore-11.3.0.eb
  • SUCCESS GCCcore-12.2.0.eb
  • SUCCESS GCCcore-13.2.0.eb

Build succeeded for 5 out of 5 (5 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/b09a6a15d4d3fe2dddbb476c8cf4de8b for a full test report.

jfgrimm
jfgrimm approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jfgrimm jfgrimm merged commit cb56be4 into easybuilders:5.0.x Feb 9, 2024
17 checks passed
@branfosj branfosj deleted the 20240201200144_new_pr_gcc branch February 9, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfgrimm jfgrimm jfgrimm approved these changes

Assignees
No one assigned
Labels
change EasyBuild-5.0 EasyBuild 5.0
Projects
EasyBuild v5.0
Status: No status
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@branfosj @jfgrimm