-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set CMake installation LIBDIR
to lib
by default in CMakeMake
easyblock
#3227
Conversation
020b8c6
to
b41683a
Compare
LIBDIR
to lib
by default in CMakeMake
easyblock
Test report by @branfosj Overview of tested easyconfigs (in order)
Build succeeded for 3 out of 3 (3 easyconfigs in total) |
Test report by @branfosj Overview of tested easyconfigs (in order)
Build succeeded for 8 out of 8 (8 easyconfigs in total) |
…_LIBDIR settings in configopts replacing easyconfig parameters
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 263 out of 312 (303 easyconfigs in total) |
I kickstarted that huge test report without thinking about it too much, not sure if the reported failures have much to do with the changes in this PR... |
For
So that is relative to the EB |
If I set
If I set
And if I do not set
All the above were tested with Until recently for
|
For |
I went through the failed tests and it boils down to 2 issues:
|
Test report by @lexming Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @lexming Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
The issue with libjpeg-turbo boils down to the missing |
Test report by @lexming Overview of tested easyconfigs (in order)
Build succeeded for 94 out of 94 (76 easyconfigs in total) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 338 out of 342 (312 easyconfigs in total) |
The 4 failures in my test report have nothing to do with the changes made in this PR, so this is ready to go... |
As discussed in the last EB5 meeting, we can set the default LIBDIR in CMake to
lib
to avoid issues with exotic cmake scripts.Changelog:
install_libdir
parameter toCMakeMake
easyblock withlib
as defaultCMAKE_INSTALL_LIBDIR
throughconfigopts
have preference overinstall_libdir