Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set $ESMFMKFILE environment variable in environment module for ESMF #3368

Merged
merged 1 commit into from
Jul 3, 2024
Merged

set $ESMFMKFILE environment variable in environment module for ESMF #3368

merged 1 commit into from
Jul 3, 2024

Conversation

lexming
Copy link
Contributor

@lexming lexming commented Jun 19, 2024 •
edited
Loading

ESMF installations should set ESMFMKFILE in the environment according to its documentation.
See section 9.9 in https://earthsystemmodeling.org/docs/release/latest/ESMF_usrdoc/node10.html

@lexming
Copy link
Contributor Author

lexming commented Jun 19, 2024

Test report by @lexming

Overview of tested easyconfigs (in order)

  • SUCCESS ESMF-8.6.0-foss-2023a.eb
  • SUCCESS ESMF-8.4.2-foss-2022a.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
node608.hydra.os - Linux Rocky Linux 8.9, x86_64, AMD EPYC 9384X 32-Core Processor (x86_64_v4), Python 3.6.8
See https://gist.github.com/lexming/0dc28b490c3ac44be12053fcd6c423fc for a full test report.

boegel
boegel approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (lib/esmf.mk is there at least for ESMF 7.0.2, which is ancient already, so should be fine going forward)

@boegel boegel changed the title set ESMFMKFILE environment variable on ESMF modules set $ESMFMKFILE environment variable in environment module for ESMF Jul 3, 2024
@boegel boegel added this to the release after 4.9.2 milestone Jul 3, 2024
@boegel boegel merged commit 96e48ff into easybuilders:develop Jul 3, 2024
41 checks passed
@lexming lexming deleted the esmfmkfile branch July 4, 2024 09:07
@lexming lexming mentioned this pull request Jul 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.9.3
Development

Successfully merging this pull request may close these issues.
2 participants
@lexming @boegel