update custom easyblock for CP2K >= v2024 #3433
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
changed the title
gkaf89
reviewed
Nov 20, 2024
| if cp2k_version >= LooseVersion('2024'): | ||
| options['DFLAGS'] += ' -D__OFFLOAD_CUDA -D__DBCSR_ACC ' | ||
| options['LIBS'] += ' -lcufft -lcudart -lnvrtc -lcuda -lcublas' | ||
| options['OFFLOAD_CC'] = 'nvcc' |
There was a problem hiding this comment.
The OFFLOAD_CC variable is used in the makefile of CP2K to build files with OpenACC offloading, even in versions older than 2024. For instance 2023.1 fails to build with CUDA support with the old easyblock.
Maybe enable the modification for some versions earlier than 2024 if they are still relevant?
There was a problem hiding this comment.
Yeah it can surely be modified, but i have not tested them with old versions, when i test them will definitely modify if required. Thanks!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, as discussed in Slack, and being based in in these three PRs:
easybuilders/easybuild-easyconfigs#17718
#2349
#2918
I have written easyblock for CP2K, during the compilation of **CP2K-2024.2-foss-2023a-CUDA-12.2.0.eb **. Almost all the tests pass except for around 50 tests of total 4000 tests fail.