Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance OpenFOAM easyblock to also build the plugins for OpenFOAM >= v2406 #3436

Merged
merged 3 commits into from
Sep 11, 2024
Merged

enhance OpenFOAM easyblock to also build the plugins for OpenFOAM >= v2406 #3436

merged 3 commits into from
Sep 11, 2024

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Sep 6, 2024

fixes #3421

@branfosj branfosj added this to the 4.x milestone Sep 6, 2024
This was referenced Sep 6, 2024
Merged
Closed
@branfosj
Copy link
Member Author

branfosj commented Sep 6, 2024

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS OpenFOAM-v2312-foss-2023a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/96209796b0ef5c751b9a9dd59b94f72f for a full test report.

@boegel boegel changed the title build the plugins for OpenFOAM enhance OpenFOAM easyblock to also build the plugins for OpenFOAM >= v2406 Sep 11, 2024
@boegel boegel modified the milestones: 4.x, 4.9.3 Sep 11, 2024
@boegel
Copy link
Member

boegel commented Sep 11, 2024

@branfosj FYI, I've synced this with develop and fixed the trivial merge conflict after the merge of #3434

boegel
boegel approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tested via easybuilders/easybuild-easyconfigs#21332

@boegel boegel merged commit fff46d0 into easybuilders:develop Sep 11, 2024
41 checks passed
@branfosj branfosj deleted the of2 branch September 11, 2024 14:22
@boegel boegel mentioned this pull request Sep 11, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.9.3
Development

Successfully merging this pull request may close these issues.

OpenFOAM v2406 is built without cfMesh package
2 participants
@branfosj @boegel