-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance AOCC EasyBlock to work with LLVM 16 and newer #3458
Enhance AOCC EasyBlock to work with LLVM 16 and newer #3458
Conversation
46a63a6
to
267f336
Compare
Enhances the AOCC EasyBlock so that internal LLVM versions newer than LLVM 16 map to the correct resource dir. In addition, update the list of AOCC to LLVM versions to the most up-to-date one, helping when writing AOCC EasyConfigs. Signed-off-by: Jan André Reuter <j.reuter@fz-juelich.de>
267f336
to
c581677
Compare
Tested with easybuilders/easybuild-easyconfigs#21343, see easybuilders/easybuild-easyconfigs#21343 (comment) If I manage to build GCCcore/12.2.0, I'll continue testing. My system GCC causes quite some issues when trying to build a GCCcore lower than GCC 13, probably due to NVPTX. |
Test report by @Thyre Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) Note: My GCCcore/12.2.0 is built without NVPTX, but this should not affect installing AOCC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@boegelbot please test @ jsc-zen3 |
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 3 out of 3 (3 easyconfigs in total) |
@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2374876762 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 3 (3 easyconfigs in total) |
Enhances the AOCC EasyBlock so that internal LLVM versions newer than LLVM 16 map to the correct resource dir. In addition, update the list of AOCC to LLVM versions to the most up-to-date one, helping when writing AOCC EasyConfigs.
This PR is an alternative to #3437, where the version was mapped during the
__init__
call of the EasyBlock, which could fail if the mapping table is used and did not represent the actual version.