Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{data}[foss/2018b] ROOT v6.14.06 w/ Python 3.6.6 #10324

Merged
merged 3 commits into from
Apr 12, 2020
Merged

{data}[foss/2018b] ROOT v6.14.06 w/ Python 3.6.6 #10324

merged 3 commits into from
Apr 12, 2020

Conversation

JackPerdue
Copy link
Contributor

(created using eb --new-pr)

@JackPerdue
Copy link
Contributor Author

Requires the patch for root.py in easybuilders/easybuild-easyblocks#2009

@lexming lexming added the update label Apr 6, 2020
@lexming lexming added this to the 4.x milestone Apr 6, 2020
lexming
lexming previously requested changes Apr 11, 2020
View reviewed changes
Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have GSL-2.5-GCC-7.3.0-2.30.eb in the tree which is in a toolchain compatible with foss/2018b. Please remove GSL-2.5-GCCcore-7.3.0.eb from this PR.
The dependencies of ROOT do not have to be changed.

@JackPerdue
Delete GSL-2.5-GCCcore-7.3.0.eb
cd20130 
I'll worry about GSL for the intel build later after the easyblock is fixed for Python3.
@easybuilders easybuilders deleted a comment from boegelbot Apr 12, 2020
@boegel boegel dismissed lexming’s stale review April 12, 2020 09:27

GSL easyconfig was removed

@easybuilders easybuilders deleted a comment from boegelbot Apr 12, 2020
@lexming lexming modified the milestones: 4.x, next release (4.2.0) Apr 12, 2020
@boegel boegel modified the milestones: next release (4.2.0), 4.x Apr 12, 2020
@boegel
Copy link
Member

boegel commented Apr 12, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2622.swalot.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 2.7.5
See https://gist.github.com/04dbd36bc542115c18500534837e1a7d for a full test report.

@boegel boegel modified the milestones: 4.x, next release (4.2.0) Apr 12, 2020
@lexming
Copy link
Contributor

lexming commented Apr 12, 2020

Test report by @lexming
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in this PR)
node150.hydra.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz, Python 2.7.5
See https://gist.github.com/0e7aa3a6469c0a99a2564f801bda3aa2 for a full test report.

@boegel
Copy link
Member

boegel commented Apr 12, 2020

@lexming Failed test report is due to easybuilders/easybuild-easyblocks#2023, shouldn't block this PR imho...

@boegel
Copy link
Member

boegel commented Apr 12, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
generoso - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/7026bb5ff9deed0b96cc6b9282f35d78 for a full test report.

@boegel
Copy link
Member

boegel commented Apr 12, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3100.skitty.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/f1ed0876af1f8664ae3d4ea4d1897830 for a full test report.

@lexming
Copy link
Contributor

lexming commented Apr 12, 2020

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node150.hydra.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz, Python 2.7.5
See https://gist.github.com/7f0cf1393dcee944520b0351e504ec56 for a full test report.

lexming
lexming approved these changes Apr 12, 2020
View reviewed changes
Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that issue easybuilders/easybuild-easyblocks#2023 is not a blocker for this PR and can be solved at a later time.

LGTM

@lexming
Copy link
Contributor

lexming commented Apr 12, 2020

Going in, thanks @JackPerdue !

@lexming lexming merged commit 5549673 into easybuilders:develop Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lexming lexming lexming approved these changes

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
update
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@JackPerdue @boegel @lexming