-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{devel,vis}[fosscuda/2019b] torchvision v0.8.1, PyTorch v1.7.0 w/ Python 3.7.4, with MKL #11786
{devel,vis}[fosscuda/2019b] torchvision v0.8.1, PyTorch v1.7.0 w/ Python 3.7.4, with MKL #11786
Conversation
…orch-1.7.0-imkl.eb, PyTorch-1.7.0-fosscuda-2019b-Python-3.7.4-imkl.eb
Requires #11636 for patches and fixes. |
builddependencies = [ | ||
('CMake', '3.15.3'), | ||
('hypothesis', '4.44.2', local_pyversionsuffix), | ||
('libarchive', '3.4.2'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be required. The error message from #11636 (comment) hints at cmake not pytorch so if at all it should be added to the cmake EC but first it should be checked why it uses the system cmake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to check, is it libarchive
or cmake
that shouldn't be required in builddependencies
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libarchive. The CMake 3.15 shouldn't need it. I see CMake-3.18.4-GCCcore-10.2.0.eb added it so I guess your system CMake is newer than 3.15 and something is wrong so the system cmake gets picked up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, ick. No idea why this happens. My familiarity with CMake isn't great. :-(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing with CMake here, only with the CMake module. As you posted the PyTorch build somehow uses /usr/bin/cmake3 which is clearly wrong. So try to load the CMake/3.15.3 module and run which cmake
and which cmake3
to check if the module is broken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I checked the PyTorch code: CMAKE = find_executable('cmake3') or find_executable('cmake')
Looks like we need an update to the CMake easyblock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, good catch. I doubt I have time to sort it right now. Make an issue of it and first one gets a cookie?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I haz my cookie please: easybuilders/easybuild-easyblocks#2259
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍪 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in 117a9bd to not need libarchive, which I didn't include in the PR anyway... I was clearly ahead of myself this morning.
This also requires the imkl modules from #11785. |
@terjekv: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/391563189
bleep, bloop, I'm just a bot (boegelbot v20200716.01) |
Can you add a ToDo to resync the 1.7 with the other PR once that is finished? |
|
closing this since |
(created using
eb --new-pr
)